cros: Clean up SessionStateDelegate refs in Chrome

cros: Clean up SessionStateDelegate refs in Chrome

Replace SessionStateDelegate references in Chrome with
available equivalents since it is deprecated.

BUG=648964
Review-Url: https://codereview.chromium.org/2661283002
Cr-Commit-Position: refs/heads/master@{#454041}
Committed: https://chromium.googlesource.com/chromium/src/+/5d8d3ba12db7577559029d5148e8f8bfe8500f62

[xiyuan, 2017-01-31 18:22:22]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 18:23:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 19:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 19:13:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2017-02-17 23:22:26]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 23:23:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 01:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:27:43]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[xiyuan, 2017-02-21 18:54:22]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 18:55:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 20:58:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 20:58:18]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[xiyuan, 2017-02-21 22:31:04]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 22:33:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 00:37:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:37:27]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[xiyuan, 2017-02-22 16:40:12]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 16:40:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 16:44:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 16:44:31]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2017-02-22 16:54:44]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 16:55:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 20:14:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 20:14:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2017-02-22 23:01:13]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 23:02:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 00:13:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 00:13:03]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-02-23 05:45:50]

Description was changed from

==========
cros: Clean up SessionStateDelegate refs in Chrome

Replace SessionStateDelegate references in Chrome with
available equivalents.

BUG=648964
==========

to

==========
cros: Clean up SessionStateDelegate refs in Chrome

Replace SessionStateDelegate references in Chrome with
available equivalents since it is deprecated.

BUG=648964
==========

[xiyuan, 2017-02-27 17:35:36]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 17:36:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2017-02-27 17:43:23]

xiyuan@chromium.org changed reviewers:
+ jamescook@chromium.org, skuhne@chromium.org

[xiyuan, 2017-02-27 17:43:25]

It is preparation of deprecating ash::SessionStateDelegate. The CL cleans up its
reference in chrome. I am working on another CL to replace it in ash. After
that, most of SessionStateDelegate can be removed.

jamescook@:
  please drive the review.

skuhne@:
  c/b/ui/ash/multi_user/*

Thanks.

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
(right):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc:3230:
// EXPECT_EQ(2, model_->item_count());
This test case is an actual bug even without this CL. The CL made
MultiUserWindowManagerChromeOS attached to the correct user and this test case
breaks. Filed a http://crbug.com/693634 to track the work for a real fix.

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
(right):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:407:
window->RemoveObserver(this);
Note this is added code. Think we need this as the symmetric reverse operation
to what we do in SetWindowOwner. It was not captured before in unit tests
because MultiUserWindowManagerChromeOS was created using
TestSessionStateDelgate's active user "First@tray", which is not the same as
default testing profile. As a result, MultiUserWindowManagerChromeOS could not
actually be attached to the user in tests thus not having all code path tested.

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/session_controller_client.cc (left):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/session_controller_client.cc:196:
gaia::CanonicalizeEmail(gaia::SanitizeEmail(account_id.GetUserEmail())));
Tests uses "a", "b" as user emails and this DCHECK fails. Remove since we don't
actually care the format of the email in the AccountId.

[commit-bot: I haz the power, 2017-02-27 18:22:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 18:22:56]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-02-27 21:20:29]

LGTM with nits

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/accessibility/accessibility_manager.cc:334:
session_state_observer_.reset();
nit: document why this has to be done here

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/accessibility/magnification_manager.cc (right):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/accessibility/magnification_manager.cc:68:
session_state_observer_.reset();
ditto

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/session_login_browsertest.cc (right):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/login/session_login_browsertest.cc:41:
EXPECT_EQ(session_manager::SessionState::OOBE,
q: Why is this now OOBE instead of LOGIN_PRIMARY?

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/DEPS (right):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/DEPS:7: "+ash/common/session",
Could this be per-file?

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
File
chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc:45:
base::StringPrintf("generated-user-%" PRIuS "@consumer.example.come",
nit: come -> com ?

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc:63:
chromeos::FakeChromeUserManager* fake_user_manager_ = nullptr;  // Not owned.
nit: comment that it is owned by |user_manager_enabler_|.

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
File
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc:294:
chromeos::FakeChromeUserManager* fake_user_manager_ = nullptr;  // Not owned.
ditto

[xiyuan, 2017-02-27 22:15:18]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[xiyuan, 2017-02-27 22:16:22]

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/accessibility/accessibility_manager.cc:334:
session_state_observer_.reset();
On 2017/02/27 21:20:28, James Cook wrote:
> nit: document why this has to be done here

I removed OnAppTerminating and moved its code here. But think again, we probably
don't need to explicitly do this. So removed the code.

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/accessibility/magnification_manager.cc (right):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/accessibility/magnification_manager.cc:68:
session_state_observer_.reset();
On 2017/02/27 21:20:28, James Cook wrote:
> ditto

Removed, same as the one in AccessibilityManager

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/chromeo...
File chrome/browser/chromeos/login/session_login_browsertest.cc (right):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/chromeo...
chrome/browser/chromeos/login/session_login_browsertest.cc:41:
EXPECT_EQ(session_manager::SessionState::OOBE,
On 2017/02/27 21:20:28, James Cook wrote:
> q: Why is this now OOBE instead of LOGIN_PRIMARY?

The old state is from SessionStateDelegateChromeOS, which always uses
LOGIN_PRIMAR and does not differentiate OOBE and LOGIN_PRIMARY.

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/DEPS (right):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/DEPS:7: "+ash/common/session",
On 2017/02/27 21:20:28, James Cook wrote:
> Could this be per-file?

Done. Good call. Learned "specific_include_rules" and find a couple more
references that need to be cleaned.

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
File
chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc:45:
base::StringPrintf("generated-user-%" PRIuS "@consumer.example.come",
On 2017/02/27 21:20:28, James Cook wrote:
> nit: come -> com ?

Done.

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc:63:
chromeos::FakeChromeUserManager* fake_user_manager_ = nullptr;  // Not owned.
On 2017/02/27 21:20:28, James Cook wrote:
> nit: comment that it is owned by |user_manager_enabler_|.

Done.

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
File
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2661283002/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc:294:
chromeos::FakeChromeUserManager* fake_user_manager_ = nullptr;  // Not owned.
On 2017/02/27 21:20:29, James Cook wrote:
> ditto

Done.

[commit-bot: I haz the power, 2017-02-27 22:16:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2017-02-27 22:20:56]

xiyuan@chromium.org changed reviewers:
+ achuith@chromium.org, dmazzoni@chromium.org, sky@chromium.org

[xiyuan, 2017-02-27 22:20:57]

+owners

sky@:
  chrome/browser/DEPS
  chrome/browser/ui/ash/DEPS
  chrome/browser/ui/views/frame/*

achuith@:
  components/user_manager/*
  chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

dmazzoni@:
  chrome/browser/chromeos/accessibility/*

Thanks.

[commit-bot: I haz the power, 2017-02-27 23:12:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 23:12:18]

Dry run: This issue passed the CQ dry run.

[sky, 2017-02-27 23:51:32]

https://codereview.chromium.org/2661283002/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/DEPS (right):

https://codereview.chromium.org/2661283002/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/DEPS:13: "+ash/common/session",
Is this temporary?

[xiyuan, 2017-02-28 00:19:58]

https://codereview.chromium.org/2661283002/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/DEPS (right):

https://codereview.chromium.org/2661283002/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/DEPS:13: "+ash/common/session",
On 2017/02/27 23:51:32, sky wrote:
> Is this temporary?

Yes, the goal is to deprecate SesisonStateDelegate. No chrome side code should
access it after this CL (except SessionStateDelegateChromeOS which implements
the interface). Ash side should switch to new SessionController (will do in
another CL). This DEPS rule can be removed with SessionStateDelegateChromeOS
when no one uses SessionStateDelgate anymore.

[sky, 2017-02-28 00:51:02]

LGTM

https://codereview.chromium.org/2661283002/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/DEPS (right):

https://codereview.chromium.org/2661283002/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/DEPS:13: "+ash/common/session",
On 2017/02/28 00:19:58, xiyuan wrote:
> On 2017/02/27 23:51:32, sky wrote:
> > Is this temporary?
> 
> Yes, the goal is to deprecate SesisonStateDelegate. No chrome side code should
> access it after this CL (except SessionStateDelegateChromeOS which implements
> the interface). Ash side should switch to new SessionController (will do in
> another CL). This DEPS rule can be removed with SessionStateDelegateChromeOS
> when no one uses SessionStateDelgate anymore.

Excellent! Can you add a comment to this effect? That this is temporary, and
possibly site the bug.

[Mr4D (OOO till 08-26), 2017-02-28 04:56:56]

Basically c/b/ui/ash/Multi_user looks good, do you know why the removeObserver
is now needed?

https://codereview.chromium.org/2661283002/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
(right):

https://codereview.chromium.org/2661283002/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:407:
window->RemoveObserver(this);
This is odd. Why wasn't this needed before?

[Mr4D (OOO till 08-26), 2017-02-28 04:56:59]

Basically c/b/ui/ash/Multi_user looks good, do you know why the removeObserver
is now needed?

[Mr4D (OOO till 08-26), 2017-02-28 04:56:59]

Basically c/b/ui/ash/Multi_user looks good, do you know why the removeObserver
is now needed?

[dmazzoni, 2017-02-28 06:17:42]

lgtm for accessibility

[xiyuan, 2017-02-28 18:35:50]

https://codereview.chromium.org/2661283002/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/DEPS (right):

https://codereview.chromium.org/2661283002/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/DEPS:13: "+ash/common/session",
On 2017/02/28 00:51:02, sky wrote:
> On 2017/02/28 00:19:58, xiyuan wrote:
> > On 2017/02/27 23:51:32, sky wrote:
> > > Is this temporary?
> > 
> > Yes, the goal is to deprecate SesisonStateDelegate. No chrome side code
should
> > access it after this CL (except SessionStateDelegateChromeOS which
implements
> > the interface). Ash side should switch to new SessionController (will do in
> > another CL). This DEPS rule can be removed with SessionStateDelegateChromeOS
> > when no one uses SessionStateDelgate anymore.
> 
> Excellent! Can you add a comment to this effect? That this is temporary, and
> possibly site the bug.

Done.

https://codereview.chromium.org/2661283002/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
(right):

https://codereview.chromium.org/2661283002/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:407:
window->RemoveObserver(this);
On 2017/02/28 04:56:56, Mr4D wrote:
> This is odd. Why wasn't this needed before?

Got the CHECK failure in WindowObserver dtor [1] when working on the CL. It is
related to switching from TestSessionStateDelegate's default user to the
FakeUserManager's default user [2]. Somehow, I could no longer repro it now. :(

I believe we still have problems though. The RemoveObserver call was in this
OnWindowDestroyed before. It was removed in
https://codereview.chromium.org/101013002 where aura::Window now calls
RemoveObserver before notifying observers about OnWindowDestroyed. However,
MultiUserWindowManagerChromeOS's destructor still calls its OnWindowDestroyed
and expects it would do RemoveObserver on the window. This is broken and causing
the CHECK.

Based on what I have learned now, I move this RemoevObserver call to the
MultiUserWindowManagerChromeOS's dtor and added a comment there.

[1]:
https://cs.chromium.org/chromium/src/ui/aura/window_observer.cc?rcl=96a656266...
[2]:
https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/multi_user/multi_u...

[xiyuan, 2017-02-28 18:36:21]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 18:36:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 18:39:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 18:39:55]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[xiyuan, 2017-02-28 19:07:24]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 19:07:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 19:55:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 19:55:27]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-02-28 23:50:07]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 23:50:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 01:36:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 01:36:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mr4D (OOO till 08-26), 2017-03-01 20:57:34]

Thanks for looking!

lgtm

[achuithb, 2017-03-01 21:04:22]

user_manager lgtm

[xiyuan, 2017-03-01 21:05:16]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2017-03-01 21:05:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, dmazzoni@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2661283002/#ps220001
(title: "update browser_finder_chromeos_unittest")

[commit-bot: I haz the power, 2017-03-01 21:05:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 21:34:46]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1488402316463350,
"parent_rev": "af14b80b50075629e1377736425000c609f7a4ac", "commit_rev":
"5d8d3ba12db7577559029d5148e8f8bfe8500f62"}

[commit-bot: I haz the power, 2017-03-01 21:35:27]

Description was changed from

==========
cros: Clean up SessionStateDelegate refs in Chrome

Replace SessionStateDelegate references in Chrome with
available equivalents since it is deprecated.

BUG=648964
==========

to

==========
cros: Clean up SessionStateDelegate refs in Chrome

Replace SessionStateDelegate references in Chrome with
available equivalents since it is deprecated.

BUG=648964

Review-Url: https://codereview.chromium.org/2661283002
Cr-Commit-Position: refs/heads/master@{#454041}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d8d3ba12db7577559029d5148e8...
==========

[commit-bot: I haz the power, 2017-03-01 21:35:32]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/5d8d3ba12db7577559029d5148e8...