chrome/browser/ui/ash/DEPS - Issue 2661283002: cros: Clean up SessionStateDelegate refs in Chrome

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/ash/DEPS

Issue 2661283002: cros: Clean up SessionStateDelegate refs in Chrome (Closed)

Patch Set: for #8 comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/memory/tab_manager.cc ('k') | chrome/browser/ui/ash/chrome_shell_delegate.cc » ('j') | chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+ash/public/interfaces",	2 "+ash/public/interfaces",

3 "+components/arc",	3 "+components/arc",

4 "+components/drive",	4 "+components/drive",

5 "+components/session_manager/core",	5 "+components/session_manager/core",

6 "+components/user_manager",	6 "+components/user_manager",

7 "+mash/shelf/public/interfaces",	7 "+mash/shelf/public/interfaces",

8 "+media",	8 "+media",

9 ]	9 ]

	10 specific_include_rules = {

	11 # Allow ash::SessionStateDelegate for SessionStateDelegateChromeOS.

	12 "session_state_delegate_chromeos\.(cc\|h)": [

	13 "+ash/common/session",
	sky 2017/02/27 23:51:32 Is this temporary? Is this temporary? xiyuan 2017/02/28 00:19:58 Yes, the goal is to deprecate SesisonStateDelegate Show quoted text On 2017/02/27 23:51:32, sky wrote: > Is this temporary? Yes, the goal is to deprecate SesisonStateDelegate. No chrome side code should access it after this CL (except SessionStateDelegateChromeOS which implements the interface). Ash side should switch to new SessionController (will do in another CL). This DEPS rule can be removed with SessionStateDelegateChromeOS when no one uses SessionStateDelgate anymore. sky 2017/02/28 00:51:02 Excellent! Can you add a comment to this effect? T Show quoted text On 2017/02/28 00:19:58, xiyuan wrote: > On 2017/02/27 23:51:32, sky wrote: > > Is this temporary? > > Yes, the goal is to deprecate SesisonStateDelegate. No chrome side code should > access it after this CL (except SessionStateDelegateChromeOS which implements > the interface). Ash side should switch to new SessionController (will do in > another CL). This DEPS rule can be removed with SessionStateDelegateChromeOS > when no one uses SessionStateDelgate anymore. Excellent! Can you add a comment to this effect? That this is temporary, and possibly site the bug. xiyuan 2017/02/28 18:35:50 Done. Show quoted text On 2017/02/28 00:51:02, sky wrote: > On 2017/02/28 00:19:58, xiyuan wrote: > > On 2017/02/27 23:51:32, sky wrote: > > > Is this temporary? > > > > Yes, the goal is to deprecate SesisonStateDelegate. No chrome side code should > > access it after this CL (except SessionStateDelegateChromeOS which implements > > the interface). Ash side should switch to new SessionController (will do in > > another CL). This DEPS rule can be removed with SessionStateDelegateChromeOS > > when no one uses SessionStateDelgate anymore. > > Excellent! Can you add a comment to this effect? That this is temporary, and > possibly site the bug. Done.
	14 ]

	15 }

OLD	NEW