Chromium Code Reviews

Unified Diff: build/config/compiler/BUILD.gn

Issue 2661023010: Allow using goma on Windows with symbol_level == 2 (Closed)
Patch Set: Fix assert placement Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 9d651ad27157f85f6aa0d723bf677abf284e614a..9202fd0abff3024778867f35b607ea9543e71864 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1580,7 +1580,12 @@ config("afdo") {
# Full symbols.
config("symbols") {
if (is_win) {
- cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
+ if (use_goma) {
+ # Note that this requires is_win_fastlink, enforced elsewhere.
+ cflags = [ "/Z7" ] # Debug information in the .obj files.
scottmg 2017/02/01 21:56:43 Can you not just set is_win_fastlink here instead
grt (UTC plus 2) 2017/02/01 22:06:37 1) You are awesome, Bruce. I was just searching fo
+ } else {
+ cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
+ }
if (is_win_fastlink) {
# Tell VS 2015+ to create a PDB that references debug
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »

Powered by Google App Engine