Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2661023010: Allow using goma on Windows with symbol_level == 2 (Closed)
Patch Set: Fix assert placement Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 1562 matching lines...) Expand 10 before | Expand all | Expand 10 after
1573 # 1573 #
1574 # You can override the symbol level on a per-target basis by removing the 1574 # You can override the symbol level on a per-target basis by removing the
1575 # default config and then adding the named one you want: 1575 # default config and then adding the named one you want:
1576 # 1576 #
1577 # configs -= [ "//build/config/compiler:default_symbols" ] 1577 # configs -= [ "//build/config/compiler:default_symbols" ]
1578 # configs += [ "//build/config/compiler:symbols" ] 1578 # configs += [ "//build/config/compiler:symbols" ]
1579 1579
1580 # Full symbols. 1580 # Full symbols.
1581 config("symbols") { 1581 config("symbols") {
1582 if (is_win) { 1582 if (is_win) {
1583 cflags = [ "/Zi" ] # Produce PDB file, no edit and continue. 1583 if (use_goma) {
1584 # Note that this requires is_win_fastlink, enforced elsewhere.
1585 cflags = [ "/Z7" ] # Debug information in the .obj files.
scottmg 2017/02/01 21:56:43 Can you not just set is_win_fastlink here instead
grt (UTC plus 2) 2017/02/01 22:06:37 1) You are awesome, Bruce. I was just searching fo
1586 } else {
1587 cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
1588 }
1584 1589
1585 if (is_win_fastlink) { 1590 if (is_win_fastlink) {
1586 # Tell VS 2015+ to create a PDB that references debug 1591 # Tell VS 2015+ to create a PDB that references debug
1587 # information in .obj and .lib files instead of copying 1592 # information in .obj and .lib files instead of copying
1588 # it all. This flag is incompatible with /PROFILE 1593 # it all. This flag is incompatible with /PROFILE
1589 ldflags = [ "/DEBUG:FASTLINK" ] 1594 ldflags = [ "/DEBUG:FASTLINK" ]
1590 } else { 1595 } else {
1591 ldflags = [ "/DEBUG" ] 1596 ldflags = [ "/DEBUG" ]
1592 } 1597 }
1593 1598
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
1679 1684
1680 if (is_ios || is_mac) { 1685 if (is_ios || is_mac) {
1681 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1686 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1682 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1687 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1683 config("enable_arc") { 1688 config("enable_arc") {
1684 common_flags = [ "-fobjc-arc" ] 1689 common_flags = [ "-fobjc-arc" ]
1685 cflags_objc = common_flags 1690 cflags_objc = common_flags
1686 cflags_objcc = common_flags 1691 cflags_objcc = common_flags
1687 } 1692 }
1688 } 1693 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698