Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: build/config/compiler/compiler.gni

Issue 2661023010: Allow using goma on Windows with symbol_level == 2 (Closed)
Patch Set: Fix assert placement Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/compiler/BUILD.gn ('K') | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/compiler.gni
diff --git a/build/config/compiler/compiler.gni b/build/config/compiler/compiler.gni
index e9e809a9061bceffc3b7b67a3e1697f6d45f5d78..e5087c7816584b57e874cdb553d4068af0836281 100644
--- a/build/config/compiler/compiler.gni
+++ b/build/config/compiler/compiler.gni
@@ -111,6 +111,9 @@ if (symbol_level == -1) {
} else {
symbol_level = 0
}
+} else if (symbol_level == 2) {
+ assert(is_win_fastlink || !use_goma,
+ "Goma builds that use symbol_level 2 must use is_win_fastlink.")
}
# Assert that the configuration isn't going to hit https://crbug.com/648948.
« build/config/compiler/BUILD.gn ('K') | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698