Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2661003003: mediaview: Recognize more MIME types. (Closed)

Created:
3 years, 10 months ago by Shuhei Takahashi
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

mediaview: Recognize more MIME types. Android uses "audio/x-wav" MIME type to describe .wav files, while Chromium knows "audio/wav" only. This patch adds hard-coded mapping between MIME types and file name extensions taken from Android. BUG=chromium:685330 TEST=unit_tests TEST=.wav files recognized in media views Review-Url: https://codereview.chromium.org/2656973003 Cr-Commit-Position: refs/heads/master@{#446633} (cherry picked from commit 588a513a3772d7cc466568f9007780aee8251003) Review-Url: https://codereview.chromium.org/2661003003 . Cr-Commit-Position: refs/branch-heads/2987@{#215} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/8844a6395ed1a3fdfc09d12fe5b24437d4aa31ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -10 lines) Patch
M chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc View 2 chunks +118 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Shuhei Takahashi
3 years, 10 months ago (2017-01-31 03:33:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8844a6395ed1a3fdfc09d12fe5b24437d4aa31ca.

Powered by Google App Engine
This is Rietveld 408576698