Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2656973003: mediaview: Recognize more MIME types. (Closed)

Created:
3 years, 10 months ago by Shuhei Takahashi
Modified:
3 years, 10 months ago
Reviewers:
hidehiko
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tzik, hidehiko+watch_chromium.org, nhiroki, lhchavez+watch_chromium.org, oshima+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mediaview: Recognize more MIME types. Android uses "audio/x-wav" MIME type to describe .wav files, while Chromium knows "audio/wav" only. This patch adds hard-coded mapping between MIME types and file name extensions taken from Android. BUG=chromium:685330 TEST=unit_tests TEST=.wav files recognized in media views Review-Url: https://codereview.chromium.org/2656973003 Cr-Commit-Position: refs/heads/master@{#446633} Committed: https://chromium.googlesource.com/chromium/src/+/588a513a3772d7cc466568f9007780aee8251003

Patch Set 1 #

Total comments: 7

Patch Set 2 : Addressed hidehiko's comments. #

Total comments: 5

Patch Set 3 : Added a short comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -10 lines) Patch
M chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc View 1 2 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc View 1 2 2 chunks +118 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Shuhei Takahashi
hidehiko: PTAL
3 years, 10 months ago (2017-01-27 07:02:22 UTC) #6
hidehiko
https://codereview.chromium.org/2656973003/diff/1/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc File chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc (right): https://codereview.chromium.org/2656973003/diff/1/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc#newcode196 chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc:196: extensions.insert(extensions.begin(), preferred_extension); Just curious: Is there a case this ...
3 years, 10 months ago (2017-01-27 07:39:45 UTC) #7
Shuhei Takahashi
PTAL https://codereview.chromium.org/2656973003/diff/1/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc File chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc (right): https://codereview.chromium.org/2656973003/diff/1/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc#newcode196 chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc:196: extensions.insert(extensions.begin(), preferred_extension); On 2017/01/27 07:39:44, hidehiko wrote: > ...
3 years, 10 months ago (2017-01-27 09:17:14 UTC) #12
hidehiko
lgtm https://codereview.chromium.org/2656973003/diff/1/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h File chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h (right): https://codereview.chromium.org/2656973003/diff/1/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h#newcode70 chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h:70: std::vector<base::FilePath::StringType> GetExtensionsForMimeTypeForArc( On 2017/01/27 09:17:14, Shuhei Takahashi wrote: ...
3 years, 10 months ago (2017-01-27 09:39:00 UTC) #13
Shuhei Takahashi
https://codereview.chromium.org/2656973003/diff/20001/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc File chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc (right): https://codereview.chromium.org/2656973003/diff/20001/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc#newcode183 chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc:183: return std::vector<base::FilePath::StringType>(); On 2017/01/27 09:39:00, hidehiko wrote: > Optional: ...
3 years, 10 months ago (2017-01-27 09:44:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656973003/40001
3 years, 10 months ago (2017-01-27 09:45:05 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 10:22:39 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/588a513a3772d7cc466568f90077...

Powered by Google App Engine
This is Rietveld 408576698