Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 2660993002: [Video] Reset new processed frame callback on the compositor thread. (Closed)

Created:
3 years, 10 months ago by whywhat
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Video] Reset new processed frame callback on the compositor thread. The callback is set and used on the compositor thread but is reset on the media thread, causing a data race. Moved resetting the callback to the OnRenderingStateChange when the state is set to false. BUG=684458 TEST=manual Review-Url: https://codereview.chromium.org/2651323002 Cr-Commit-Position: refs/heads/master@{#446515} (cherry picked from commit b5c8d0d1bed4056880ad70ed949714f9edc0f81b) Review-Url: https://codereview.chromium.org/2660993002 . Cr-Commit-Position: refs/branch-heads/2987@{#178} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/8249e65739295d3aa951eba40de6221e3b11aae6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/blink/video_frame_compositor.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
whywhat
3 years, 10 months ago (2017-01-30 20:15:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8249e65739295d3aa951eba40de6221e3b11aae6.

Powered by Google App Engine
This is Rietveld 408576698