Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2651323002: [Video] Reset new processed frame callback on the compositor thread. (Closed)

Created:
3 years, 11 months ago by whywhat
Modified:
3 years, 11 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Video] Reset new processed frame callback on the compositor thread. The callback is set and used on the compositor thread but is reset on the media thread, causing a data race. Moved resetting the callback to the OnRenderingStateChange when the state is set to false. BUG=684458 TEST=manual Review-Url: https://codereview.chromium.org/2651323002 Cr-Commit-Position: refs/heads/master@{#446515} Committed: https://chromium.googlesource.com/chromium/src/+/b5c8d0d1bed4056880ad70ed949714f9edc0f81b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/blink/video_frame_compositor.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
whywhat
PTaL
3 years, 11 months ago (2017-01-26 06:39:41 UTC) #2
DaleCurtis
Whoops, sorry I missed this in earlier review, lgtm
3 years, 11 months ago (2017-01-26 17:32:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651323002/1
3 years, 11 months ago (2017-01-27 00:59:27 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 01:13:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b5c8d0d1bed4056880ad70ed9497...

Powered by Google App Engine
This is Rietveld 408576698