Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2660633002: FrameView: Don't throttle display:none frames (Closed)

Created:
3 years, 10 months ago by Sami
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

FrameView: Don't throttle display:none frames While migrating to use IntersectionObserver to control frame throttling we accidentally also started throttling display:none frames (which IObs. considers invisible). This is not safe because many sites use such frames for driving UI logic. This patch disallows throttling for display:none frames. The revised logic also matches the frame throttling implementation in Safari. BUG=680925 TEST=Open the login popup twice on http://www.espn.in/ and observe no delay. Review-Url: https://codereview.chromium.org/2658063002 Cr-Commit-Position: refs/heads/master@{#446419} (cherry picked from commit 02d1c14d47b948cf6b4eb49c3b4cef697525f03e) Review-Url: https://codereview.chromium.org/2660633002 . Cr-Commit-Position: refs/branch-heads/2987@{#141} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/613b3cabab9f93e9c01962c327239b2f6c81d9c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +12 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Sami
3 years, 10 months ago (2017-01-27 10:43:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
613b3cabab9f93e9c01962c327239b2f6c81d9c5.

Powered by Google App Engine
This is Rietveld 408576698