FrameView: Don't throttle display:none frames

FrameView: Don't throttle display:none frames

While migrating to use IntersectionObserver to control frame throttling
we accidentally also started throttling display:none frames (which IObs.
considers invisible). This is not safe because many sites use such
frames for driving UI logic.

This patch disallows throttling for display:none frames. The revised
logic also matches the frame throttling implementation in Safari.

BUG=680925
TEST=Open the login popup twice on http://www.espn.in/ and observe no delay.

Review-Url: https://codereview.chromium.org/2658063002
Cr-Commit-Position: refs/heads/master@{#446419}
Committed: https://chromium.googlesource.com/chromium/src/+/02d1c14d47b948cf6b4eb49c3b4cef697525f03e

[Sami, 2017-01-26 15:12:32]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 15:12:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2017-01-26 15:14:45]

Description was changed from

==========
Don't throttle display:none frames

While migrating to use IntersectionObserver to control frame throttling
we accidentally also started throttling display:none frames (which IObs.
considers invisible). This is not safe because many sites use such
frames for driving UI logic. This logic also matches the frame
throttling implementation in Safari.

BUG=680925
==========

to

==========
FrameView: Don't throttle display:none frames

While migrating to use IntersectionObserver to control frame throttling
we accidentally also started throttling display:none frames (which IObs.
considers invisible). This is not safe because many sites use such
frames for driving UI logic. This logic also matches the frame
throttling implementation in Safari.

BUG=680925
TEST=Open the login popup twice on http://www.espn.in/ and observe no delay.
==========

[Sami, 2017-01-26 15:18:30]

Description was changed from

==========
FrameView: Don't throttle display:none frames

While migrating to use IntersectionObserver to control frame throttling
we accidentally also started throttling display:none frames (which IObs.
considers invisible). This is not safe because many sites use such
frames for driving UI logic. This logic also matches the frame
throttling implementation in Safari.

BUG=680925
TEST=Open the login popup twice on http://www.espn.in/ and observe no delay.
==========

to

==========
FrameView: Don't throttle display:none frames

While migrating to use IntersectionObserver to control frame throttling
we accidentally also started throttling display:none frames (which IObs.
considers invisible). This is not safe because many sites use such
frames for driving UI logic.

This patch disallows throttling for display:none frames. The revised
logic also matches the frame throttling implementation in Safari.

BUG=680925
TEST=Open the login popup twice on http://www.espn.in/ and observe no delay.
==========

[Sami, 2017-01-26 15:18:30]

skyostil@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2017-01-26 19:32:22]

LGTM

+cc wangxianzhu just fyi

[Sami, 2017-01-26 19:40:42]

The CQ bit was unchecked by skyostil@chromium.org

[Sami, 2017-01-26 19:40:47]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2017-01-26 19:41:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 20:08:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485459647403390, "parent_rev":
"1ad1446d884b37de735656e3bbf8c3e040a4852e", "commit_rev":
"02d1c14d47b948cf6b4eb49c3b4cef697525f03e"}

[commit-bot: I haz the power, 2017-01-26 20:08:39]

Description was changed from

==========
FrameView: Don't throttle display:none frames

While migrating to use IntersectionObserver to control frame throttling
we accidentally also started throttling display:none frames (which IObs.
considers invisible). This is not safe because many sites use such
frames for driving UI logic.

This patch disallows throttling for display:none frames. The revised
logic also matches the frame throttling implementation in Safari.

BUG=680925
TEST=Open the login popup twice on http://www.espn.in/ and observe no delay.
==========

to

==========
FrameView: Don't throttle display:none frames

While migrating to use IntersectionObserver to control frame throttling
we accidentally also started throttling display:none frames (which IObs.
considers invisible). This is not safe because many sites use such
frames for driving UI logic.

This patch disallows throttling for display:none frames. The revised
logic also matches the frame throttling implementation in Safari.

BUG=680925
TEST=Open the login popup twice on http://www.espn.in/ and observe no delay.

Review-Url: https://codereview.chromium.org/2658063002
Cr-Commit-Position: refs/heads/master@{#446419}
Committed:
https://chromium.googlesource.com/chromium/src/+/02d1c14d47b948cf6b4eb49c3b4c...
==========

[commit-bot: I haz the power, 2017-01-26 20:08:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02d1c14d47b948cf6b4eb49c3b4c...

[esprehn, 2017-02-14 00:05:21]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2017-02-14 00:05:22]

https://codereview.chromium.org/2658063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2658063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameView.cpp:4648:
updateRenderThrottlingStatus(m_hiddenForThrottling, m_subtreeThrottled);
This introduces an entire frame tree walk down here, which is redundant with the
frame tree walk that's happening on the following lines.

[Sami, 2017-02-21 12:34:04]

https://codereview.chromium.org/2658063002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2658063002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameView.cpp:4648:
updateRenderThrottlingStatus(m_hiddenForThrottling, m_subtreeThrottled);
On 2017/02/14 00:05:21, esprehn wrote:
> This introduces an entire frame tree walk down here, which is redundant with
the
> frame tree walk that's happening on the following lines.

Well spotted -- fix here: https://codereview.chromium.org/2706193003/