Adapt StringBuilder's append and toString methods via StringUtil helper.

Adapt StringBuilder's append and toString methods via StringUtil helper.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will change wtf::StringBuilder::toString into ToString,
and similarily will rename reserveCapacity and append methods).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new methods of StringUtil adapter:
rolling third_party/inspector to 1a131872167f0f7653629326891aa3ec94417f27.

BUG=683447
Review-Url: https://codereview.chromium.org/2660503002
Cr-Commit-Position: refs/heads/master@{#42750}
Committed: https://chromium.googlesource.com/v8/v8/+/01a93925c1f502516f4d29dfa79c7271ed6b0e5f

[Łukasz Anforowicz, 2017-01-26 20:43:27]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 20:43:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 20:59:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 20:59:45]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[Łukasz Anforowicz, 2017-01-26 22:07:09]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 22:07:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 22:10:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 22:10:23]

Dry run: Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[Łukasz Anforowicz, 2017-01-26 22:31:47]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 22:31:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-01-26 23:00:29]

lukasza@chromium.org changed reviewers:
+ dgozman@chromium.org

[Łukasz Anforowicz, 2017-01-26 23:00:29]

dgozman@, could you PTAL?

https://codereview.chromium.org/2660503002/diff/1/third_party/inspector_proto...
File third_party/inspector_protocol/README.v8 (right):

https://codereview.chromium.org/2660503002/diff/1/third_party/inspector_proto...
third_party/inspector_protocol/README.v8:5: Revision: DO NOT SUBMIT / TODO /
FIXME
Before landing *this* CL, I'll update the revision above to point to
https://codereview.chromium.org/2655203003 (once it lands in the other repo - in
https://chromium.googlesource.com/deps/inspector_protocol).

[commit-bot: I haz the power, 2017-01-26 23:04:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:04:13]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-01-26 23:11:20]

Please add "rolling third_party/inspector_protocol to <hash>" to CL description.

lgtm

[Łukasz Anforowicz, 2017-01-27 17:08:37]

Description was changed from

==========
Adapt StringBuilder's append and toString methods via StringUtil helper.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will change wtf::StringBuilder::toString into ToString,
and similarily will rename reserveCapacity and append methods).

BUG=683447
==========

to

==========
Adapt StringBuilder's append and toString methods via StringUtil helper.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will change wtf::StringBuilder::toString into ToString,
and similarily will rename reserveCapacity and append methods).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new methods of StringUtil adapter:
73028acaa3646789fd2a3bfd0d79eb2d91b696b3.

BUG=683447
==========

[Łukasz Anforowicz, 2017-01-27 17:08:46]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 17:08:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-01-27 17:11:47]

Description was changed from

==========
Adapt StringBuilder's append and toString methods via StringUtil helper.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will change wtf::StringBuilder::toString into ToString,
and similarily will rename reserveCapacity and append methods).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new methods of StringUtil adapter:
73028acaa3646789fd2a3bfd0d79eb2d91b696b3.

BUG=683447
==========

to

==========
Adapt StringBuilder's append and toString methods via StringUtil helper.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will change wtf::StringBuilder::toString into ToString,
and similarily will rename reserveCapacity and append methods).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new methods of StringUtil adapter:
1a131872167f0f7653629326891aa3ec94417f27.

BUG=683447
==========

[Łukasz Anforowicz, 2017-01-27 17:13:21]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 17:13:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-01-27 17:16:28]

On 2017/01/26 23:11:20, dgozman wrote:
> Please add "rolling third_party/inspector_protocol to <hash>" to CL
description.

Done - I've added the following paragraph to the CL description:

    This CL also includes roll of inspector_protocol which starts to
    generate code that uses the new methods of StringUtil adapter:
    1a131872167f0f7653629326891aa3ec94417f27.

I've also updated README.v8 to point at the current revision/hash of
inspector_protocol.

> lgtm

I am running a CQ dry-run right now.  I plan to land via CQ later today - please
shout if you'd like me to make some additional tweaks before doing this.

I think now I've got the right commit hash (initially I've used the local one -
oops...).

[commit-bot: I haz the power, 2017-01-27 17:45:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 17:45:28]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2017-01-27 18:22:43]

Description was changed from

==========
Adapt StringBuilder's append and toString methods via StringUtil helper.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will change wtf::StringBuilder::toString into ToString,
and similarily will rename reserveCapacity and append methods).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new methods of StringUtil adapter:
1a131872167f0f7653629326891aa3ec94417f27.

BUG=683447
==========

to

==========
Adapt StringBuilder's append and toString methods via StringUtil helper.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will change wtf::StringBuilder::toString into ToString,
and similarily will rename reserveCapacity and append methods).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new methods of StringUtil adapter:
rolling third_party/inspector to 1a131872167f0f7653629326891aa3ec94417f27.

BUG=683447
==========

[Łukasz Anforowicz, 2017-01-27 21:09:15]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-01-27 21:09:15]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2660503002/#ps80001
(title: "Corrected the revision number... :-/")

[commit-bot: I haz the power, 2017-01-27 21:09:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 21:11:16]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485551355060530,
"parent_rev": "966355585bb3e6e21c063c2b670045f5a75e5aa5", "commit_rev":
"01a93925c1f502516f4d29dfa79c7271ed6b0e5f"}

[commit-bot: I haz the power, 2017-01-27 21:11:20]

Description was changed from

==========
Adapt StringBuilder's append and toString methods via StringUtil helper.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will change wtf::StringBuilder::toString into ToString,
and similarily will rename reserveCapacity and append methods).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new methods of StringUtil adapter:
rolling third_party/inspector to 1a131872167f0f7653629326891aa3ec94417f27.

BUG=683447
==========

to

==========
Adapt StringBuilder's append and toString methods via StringUtil helper.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will change wtf::StringBuilder::toString into ToString,
and similarily will rename reserveCapacity and append methods).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new methods of StringUtil adapter:
rolling third_party/inspector to 1a131872167f0f7653629326891aa3ec94417f27.

BUG=683447

Review-Url: https://codereview.chromium.org/2660503002
Cr-Commit-Position: refs/heads/master@{#42750}
Committed:
https://chromium.googlesource.com/v8/v8/+/01a93925c1f502516f4d29dfa79c7271ed6...
==========

[commit-bot: I haz the power, 2017-01-27 21:11:21]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/01a93925c1f502516f4d29dfa79c7271ed6...