Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2655203003: Adapt StringBuilder's append and toString methods via StringUtil helper. (Closed)

Created:
3 years, 11 months ago by Łukasz Anforowicz
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adapt StringBuilder's append and toString methods via StringUtil helper. This is needed to insulate generated code from blink::protocol namespace from naming changes that we plan to do in the Great Blink Rename (which in particular will change wtf::StringBuilder::toString into ToString, and similarily will rename reserveCapacity and append methods). BUG=683447 R=dgozman@chromium.org Committed: https://chromium.googlesource.com/deps/inspector_protocol1a131872167f0f7653629326891aa3ec94417f27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -38 lines) Patch
M lib/ErrorSupport_cpp.template View 2 chunks +8 lines, -8 lines 0 comments Download
M lib/Parser_cpp.template View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/Values_cpp.template View 10 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Łukasz Anforowicz
dgozman@, could you PTAL? Changes in this CL are the same (i.e. I've just copied ...
3 years, 11 months ago (2017-01-26 23:01:59 UTC) #2
dgozman
lgtm
3 years, 11 months ago (2017-01-26 23:08:41 UTC) #3
Łukasz Anforowicz
3 years, 10 months ago (2017-01-27 17:02:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a131872167f0f7653629326891aa3ec94417f27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698