Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2660473002: Ensure field type is Payment before showing Payment Not Secure Warning (Closed)
Patch Set: Add unit test to detect regressions Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index ffcb81331349b33f17efea0dcdb18ac400b36ae8..ec7b5193bbd1a88f89a3e9a37356d17d8c4d0923 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -638,7 +638,7 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
}
// Show a "Payment not secure" message.
- if (!is_context_secure && is_http_warning_enabled) {
+ if (!is_context_secure && is_filling_credit_card && is_http_warning_enabled) {
#if !defined(OS_ANDROID)
if (!suggestions.empty()) {
suggestions.insert(suggestions.begin(), Suggestion());
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698