Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2691)

Unified Diff: gin/public/isolate_holder.h

Issue 2660423003: Atomics.wait throws when called on the main thread. (Closed)
Patch Set: nit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/isolate_holder.cc ('k') | third_party/WebKit/LayoutTests/fast/workers/resources/worker-atomics-wait.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/public/isolate_holder.h
diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h
index 62b871085805716db97938f3dda6a44888cbfca6..0d9cb3b39ef17561c090cf57d0f8dc916a67f0c7 100644
--- a/gin/public/isolate_holder.h
+++ b/gin/public/isolate_holder.h
@@ -41,6 +41,12 @@ class GIN_EXPORT IsolateHolder {
kUseLocker
};
+ // Whether Atomics.wait can be called on this isolate.
+ enum AllowAtomicsWaitMode {
+ kDisallowAtomicsWait,
+ kAllowAtomicsWait
+ };
+
// Indicates whether V8 works with stable or experimental v8 extras.
enum V8ExtrasMode {
kStableV8Extras,
@@ -51,6 +57,9 @@ class GIN_EXPORT IsolateHolder {
scoped_refptr<base::SingleThreadTaskRunner> task_runner);
IsolateHolder(scoped_refptr<base::SingleThreadTaskRunner> task_runner,
AccessMode access_mode);
+ IsolateHolder(scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+ AccessMode access_mode,
+ AllowAtomicsWaitMode atomics_wait_mode);
~IsolateHolder();
// Should be invoked once before creating IsolateHolder instances to
« no previous file with comments | « gin/isolate_holder.cc ('k') | third_party/WebKit/LayoutTests/fast/workers/resources/worker-atomics-wait.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698