Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2660423002: M57: service worker: Add UMA for navigation preload response timing. (Closed)

Created:
3 years, 10 months ago by falken
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

M57: service worker: Add UMA for navigation preload response timing. This should help understand how nav preload is doing in the wild: whether it or sw startup is finishing first, and the timings for concurrent startup and preload, and how long we end up waiting for one after the other has finished. Added are: - ServiceWorker.NavigationPreload.ConcurrentTime: the time when both startup and preload are happening concurrently - ServiceWorker.NavigationPreload.FinishedBeforeStartWorker: indicates which one finished first - ServiceWorker.NavigationPreload.NavPreloadAfterSWStart: the time spent waiting for nav preload to finish, after sw start finished - ServiceWorker.NavigationPreload.SWStartAfterNavPreload: the reverse - ServiceWorker.NavigationPreload.ResponseTime: the time it took for the nav preload response to arrive In addition, there are suffixed histograms of the above to break down the timings in the two winner scenarios, and furthmore to see the breakdowns in the interesting situation of when a SW needed to be started up. BUG=661090 Review-Url: https://codereview.chromium.org/2652603002 Cr-Commit-Position: refs/heads/master@{#445965} (cherry picked from commit 402d868859229cf42674996b82f3468922afc628) Review-Url: https://codereview.chromium.org/2660423002 . Cr-Commit-Position: refs/branch-heads/2987@{#201} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/7b811195204dbfaa7b2a3028611f9fa7a678b5c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+422 lines, -12 lines) Patch
M content/browser/service_worker/service_worker_fetch_dispatcher.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 5 chunks +11 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.h View 1 chunk +13 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.cc View 1 chunk +78 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics_unittest.cc View 1 chunk +146 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 2 chunks +39 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 2 chunks +27 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 5 chunks +105 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
falken
3 years, 10 months ago (2017-01-30 23:36:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7b811195204dbfaa7b2a3028611f9fa7a678b5c3.

Powered by Google App Engine
This is Rietveld 408576698