Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2660423002: M57: service worker: Add UMA for navigation preload response timing. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_url_request_job.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index e67d2c6acab8faace3bb8cac0b223048c91c6ff8..348ac5edb1262e00edb3076a711c9de07b47b135 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -60362,6 +60362,35 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="ServiceWorker.NavigationPreload.ConcurrentTime" units="ms">
+ <owner>falken@chromium.org</owner>
+ <summary>
+ The duration of time when both (1) a service worker is being found and
+ possibly started up, (2) the navigation preload request is in-flight. The
+ measurement ends once either the worker is prepared, or the navigation
+ preload response is received (OnReceiveResponse() is called). This is a
+ rough estimate of the performance win of using navigation preload, ignoring
+ concurrency overhead. This histogram is recorded when a navigation preload
+ response is succesfully forwarded to the service worker's fetch event, with
+ the same restrictions as for
+ ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time. The sample is
+ additionally recorded to the appropriate suffixed histograms.
+ </summary>
+</histogram>
+
+<histogram name="ServiceWorker.NavigationPreload.FinishedBeforeStartWorker"
+ enum="BooleanNavPreloadFinishedFirst">
+ <owner>falken@chromium.org</owner>
+ <summary>
+ Whether the navigation preload response arrived before the activated and
+ running service worker was prepared. This histogram is recorded when a
+ navigation preload response is succesfully forwarded to the service worker's
+ fetch event, with the same restrictions as for
+ ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time. The sample is
+ additionally recorded to the appropriate suffixed histograms.
+ </summary>
+</histogram>
+
<histogram name="ServiceWorker.NavigationPreload.HeaderSize" units="bytes">
<owner>horo@chromium.org</owner>
<summary>
@@ -60371,6 +60400,51 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="ServiceWorker.NavigationPreload.NavPreloadAfterSWStart"
+ units="ms">
+ <owner>falken@chromium.org</owner>
+ <summary>
+ This is recorded in the case where the activated and running service worker
+ was prepared before the navigation preload response arrived. It is the
+ remaining time it took to receive the response after the worker was
+ prepared.
+
+ This histogram is recorded when a navigation preload response is succesfully
+ forwarded to the service worker's fetch event (for the case mentioned
+ above), with the same restrictions as for
+ ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time. The sample is
+ additionally recorded to the appropriate suffixed histograms.
+ </summary>
+</histogram>
+
+<histogram name="ServiceWorker.NavigationPreload.ResponseTime" units="ms">
+ <owner>falken@chromium.org</owner>
+ <summary>
+ The time taken for the navigation preload response to start, i.e., when
+ OnReceiveResponse() is called. This histogram is recorded when a navigation
+ preload response is successfully forwarded to the service worker's fetch
+ event, with the same restrictions as for
+ ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time. The sample is
+ additionally recorded to the appropriate suffixed histograms.
+ </summary>
+</histogram>
+
+<histogram name="ServiceWorker.NavigationPreload.SWStartAfterNavPreload"
+ units="ms">
+ <owner>falken@chromium.org</owner>
+ <summary>
+ This is recorded in the case where the navigation preload response arrived
+ before the activated and running service worker was prepared. It is the
+ remaining time it took to prepare the worker after the response arrived.
+
+ This histogram is recorded when a navigation preload response is succesfully
+ forwarded to the service worker's fetch event (for the case mentioned
+ above), with the same restrictions as for
+ ServiceWorker.ActivatedWorkerPreparationForMainFrame.Time. The sample is
+ additionally recorded to the appropriate suffixed histograms.
+ </summary>
+</histogram>
+
<histogram name="ServiceWorker.NotificationClickEvent.Time" units="ms">
<owner>peter@chromium.org</owner>
<summary>
@@ -79352,6 +79426,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="1" label="Missing data in disk cache"/>
</enum>
+<enum name="BooleanNavPreloadFinishedFirst" type="int">
+ <int value="0" label="Worker preparation finished first"/>
+ <int value="1" label="Navigation preload response arrived first"/>
+</enum>
+
<enum name="BooleanNeedsClearing" type="int">
<int value="0" label="Doesn't need clearing"/>
<int value="1" label="Needs to be clearred"/>
@@ -113214,6 +113293,16 @@ value.
name="ServiceWorker.ActivatedWorkerPreparationForMainFrame.Type"/>
</histogram_suffixes>
+<histogram_suffixes name="NavigationPreloadOrWorkerFirst">
+ <suffix name="SWStartFirst"
+ label="The service worker finished preparing before the navigation
+ preload response arrived."/>
+ <suffix name="NavPreloadFirst"
+ label="The navigation preload response arrived before the service
+ worker finished preparing."/>
+ <affected-histogram name="ServiceWorker.NavigationPreload.ConcurrentTime"/>
+</histogram_suffixes>
+
<histogram_suffixes name="Net.BidirectionalStreamExperiment" separator=".">
<owner>xunjieli@chromium.org</owner>
<suffix name="QUIC" label="Bidirectional streams that use QUIC protocol"/>
@@ -117557,6 +117646,22 @@ value.
<affected-histogram name="StartupTimeBomb.Alarm"/>
</histogram_suffixes>
+<histogram_suffixes name="StartWorkerExistingProcess">
+ <suffix name="StartWorkerExistingProcess"
+ label="The worker started up in an existing process"/>
+ <affected-histogram name="ServiceWorker.NavigationPreload.ConcurrentTime"/>
+ <affected-histogram
+ name="ServiceWorker.NavigationPreload.ConcurrentTime_NavPreloadFirst"/>
+ <affected-histogram
+ name="ServiceWorker.NavigationPreload.ConcurrentTime_SWStartFirst"/>
+ <affected-histogram
+ name="ServiceWorker.NavigationPreload.FinishedBeforeStartWorker"/>
+ <affected-histogram
+ name="ServiceWorker.NavigationPreload.NavPreloadAfterSWStart"/>
+ <affected-histogram
+ name="ServiceWorker.NavigationPreload.SWStartAfterNavPreload"/>
+</histogram_suffixes>
+
<histogram_suffixes name="Storage.BlobAppendableItems" separator=".">
<suffix name="Bytes" label="Appending bytes."/>
<suffix name="File" label="Appending a file with a known size."/>
« no previous file with comments | « content/browser/service_worker/service_worker_url_request_job.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698