Convert RenderViewHostTest to use the new navigation callbacks.

Convert RenderViewHostTest to use the new navigation callbacks.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2660403006
Cr-Commit-Position: refs/heads/master@{#447953}
Committed: https://chromium.googlesource.com/chromium/src/+/ee59954e558b897d48fb154918d3383fc574f024

[jam, 2017-01-31 21:55:01]

Description was changed from

==========
Convert RenderViewHostTest to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert RenderViewHostTest to use the new navigation callbacks.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-01-31 21:55:10]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-01-31 21:55:41]

Description was changed from

==========
Convert RenderViewHostTest to use the new navigation callbacks.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert RenderViewHostTest to use the new navigation callbacks.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-01-31 21:55:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-31 21:55:42]

jam@chromium.org changed reviewers:
+ nasko@chromium.org

[jam, 2017-01-31 23:59:44]

https://codereview.chromium.org/2660403006/diff/1/content/public/browser/navi...
File content/public/browser/navigation_handle.h (right):

https://codereview.chromium.org/2660403006/diff/1/content/public/browser/navi...
content/public/browser/navigation_handle.h:181: virtual net::HostPortPair
GetSocketAddress() = 0;
this is used by safe browsing code (outside of content), which is why I made it
public now.

[commit-bot: I haz the power, 2017-02-01 00:00:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 00:00:08]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[nasko, 2017-02-02 16:18:38]

https://codereview.chromium.org/2660403006/diff/1/content/public/browser/navi...
File content/public/browser/navigation_handle.h (right):

https://codereview.chromium.org/2660403006/diff/1/content/public/browser/navi...
content/public/browser/navigation_handle.h:181: virtual net::HostPortPair
GetSocketAddress() = 0;
On 2017/01/31 23:59:44, jam wrote:
> this is used by safe browsing code (outside of content), which is why I made
it
> public now.

But I don't see changes in chrome/ in this CL. Can you include those changes or
just expose it in a CL that fixes SB code?

[jam, 2017-02-03 05:26:56]

https://codereview.chromium.org/2660403006/diff/1/content/public/browser/navi...
File content/public/browser/navigation_handle.h (right):

https://codereview.chromium.org/2660403006/diff/1/content/public/browser/navi...
content/public/browser/navigation_handle.h:181: virtual net::HostPortPair
GetSocketAddress() = 0;
On 2017/02/02 16:18:37, nasko (very slow) wrote:
> On 2017/01/31 23:59:44, jam wrote:
> > this is used by safe browsing code (outside of content), which is why I made
> it
> > public now.
> 
> But I don't see changes in chrome/ in this CL. Can you include those changes
or
> just expose it in a CL that fixes SB code?

Right, I'm landing each conversion separately to make it easier to track down
regressions if any come up. So I'll land the SB one separately.

I didn't see much benefit for landing this cl with a hacker_style getter in
content, only to remove it the next day and replace it with a public getter.

[nasko, 2017-02-03 05:31:03]

On 2017/02/03 05:26:56, jam wrote:
>
https://codereview.chromium.org/2660403006/diff/1/content/public/browser/navi...
> File content/public/browser/navigation_handle.h (right):
> 
>
https://codereview.chromium.org/2660403006/diff/1/content/public/browser/navi...
> content/public/browser/navigation_handle.h:181: virtual net::HostPortPair
> GetSocketAddress() = 0;
> On 2017/02/02 16:18:37, nasko (very slow) wrote:
> > On 2017/01/31 23:59:44, jam wrote:
> > > this is used by safe browsing code (outside of content), which is why I
made
> > it
> > > public now.
> > 
> > But I don't see changes in chrome/ in this CL. Can you include those changes
> or
> > just expose it in a CL that fixes SB code?
> 
> Right, I'm landing each conversion separately to make it easier to track down
> regressions if any come up. So I'll land the SB one separately.
> 
> I didn't see much benefit for landing this cl with a hacker_style getter in
> content, only to remove it the next day and replace it with a public getter.

Ok, LGTM

[jam, 2017-02-03 05:49:27]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-02-03 05:49:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 07:03:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486100967354040, "parent_rev":
"9071e0ea6e201c38826160e2c397327a9681473e", "commit_rev":
"ee59954e558b897d48fb154918d3383fc574f024"}

[commit-bot: I haz the power, 2017-02-03 07:04:14]

Description was changed from

==========
Convert RenderViewHostTest to use the new navigation callbacks.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert RenderViewHostTest to use the new navigation callbacks.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2660403006
Cr-Commit-Position: refs/heads/master@{#447953}
Committed:
https://chromium.googlesource.com/chromium/src/+/ee59954e558b897d48fb154918d3...
==========

[commit-bot: I haz the power, 2017-02-03 07:04:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ee59954e558b897d48fb154918d3...