Convert RenderViewHostTest to use the new navigation callbacks.

content/public/browser/navigation_handle.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
 
 #include <memory>
 #include <string>
 
 #include "content/common/content_export.h"
 #include "content/public/browser/navigation_throttle.h"
 #include "content/public/browser/reload_type.h"
 #include "content/public/common/referrer.h"
+#include "net/base/host_port_pair.h"
 #include "net/base/net_errors.h"
 #include "net/http/http_response_info.h"
 #include "ui/base/page_transition_types.h"
 
 class GURL;
 
 namespace net {
 class HttpResponseHeaders;
 }  // namespace net
 
@@ skipping 144 matching lines @@
   // successful commits or error pages that replace the previous page
   // (distinguished by |IsErrorPage|), and false for errors that leave the user
   // on the previous page.
   virtual bool HasCommitted() = 0;
 
   // Whether the navigation resulted in an error page.
   // Note that if an error page reloads, this will return true even though
   // GetNetErrorCode will be net::OK.
   virtual bool IsErrorPage() = 0;
 
+  // Returns the remote address of the socket which fetched this resource.
+  virtual net::HostPortPair GetSocketAddress() = 0;

[jam, 2017/01/31 23:59:44]

this is used by safe browsing code (outside of content), which is why I made it
public now.

[nasko, 2017/02/02 16:18:37]

But I don't see changes in chrome/ in this CL. Can you include those changes or
just expose it in a CL that fixes SB code?

[jam, 2017/02/03 05:26:56]

Right, I'm landing each conversion separately to make it easier to track down
regressions if any come up. So I'll land the SB one separately.

I didn't see much benefit for landing this cl with a hacker_style getter in
content, only to remove it the next day and replace it with a public getter.

+
   // Returns the response headers for the request, or nullptr if there aren't
   // any response headers or they have not been received yet. The response
   // headers may change during the navigation (e.g. after encountering a server
   // redirect). The headers returned should not be modified, as modifications
   // will not be reflected in the network stack.
   virtual const net::HttpResponseHeaders* GetResponseHeaders() = 0;
 
   // Returns the connection info for the request, the default value is
   // CONNECTION_INFO_UNKNOWN if there hasn't been a response (or redirect)
   // yet. The connection info may change during the navigation (e.g. after
@@ skipping 67 matching lines @@
 
   // The NavigationData that the embedder returned from
   // ResourceDispatcherHostDelegate::GetNavigationData during commit. This will
   // be a clone of the NavigationData.
   virtual NavigationData* GetNavigationData() = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_