Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 266033002: Collect data reduction proxy UMA on all platforms (Closed)

Created:
6 years, 7 months ago by bengr
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Collect data reduction proxy UMA on all platforms UMA for the data reduction proxy was gated behind preprocessor directives that resticted the logic to Android and iOS. This change opens UMA calculations and collection up to all platforms. BUG=369619 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269026 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269670

Patch Set 1 : #

Patch Set 2 : Workaround for base::Time::Explode bug in Windows #

Total comments: 1

Patch Set 3 : Fix static initializer #

Patch Set 4 : the set_key interface is in another CL #

Patch Set 5 : Remove ifdef from HttpResponseHeaders::IsDataReductionProxyResponse() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -39 lines) Patch
M chrome/browser/net/chrome_network_delegate.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/page_load_histograms.cc View 1 2 3 4 4 chunks +1 line, -8 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h View 2 chunks +0 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc View 1 9 chunks +10 lines, -15 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_metrics_unittest.cc View 6 chunks +0 lines, -8 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_prefs.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/http/http_response_headers.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_headers.cc View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M net/http/http_response_headers_unittest.cc View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (0 generated)
bengr
mef: chrome/browser/net/* marq: components/data_reduction_proxy/*
6 years, 7 months ago (2014-05-06 20:27:41 UTC) #1
marq (ping after 24h)
LGTM.
6 years, 7 months ago (2014-05-06 20:45:56 UTC) #2
mef
lgtm
6 years, 7 months ago (2014-05-06 21:17:31 UTC) #3
bengr
The CQ bit was checked by bengr@chromium.org
6 years, 7 months ago (2014-05-06 21:19:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bengr@chromium.org/266033002/40001
6 years, 7 months ago (2014-05-06 21:20:17 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 03:25:15 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #2). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 10:00:12 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-07 12:03:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-07 12:03:46 UTC) #9
bengr
The CQ bit was checked by bengr@chromium.org
6 years, 7 months ago (2014-05-07 18:08:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bengr@chromium.org/266033002/40001
6 years, 7 months ago (2014-05-07 18:11:57 UTC) #11
bengr
The CQ bit was checked by bengr@chromium.org
6 years, 7 months ago (2014-05-08 00:00:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bengr@chromium.org/266033002/70001
6 years, 7 months ago (2014-05-08 00:03:53 UTC) #13
commit-bot: I haz the power
Change committed as 269026
6 years, 7 months ago (2014-05-08 04:12:09 UTC) #14
tapted
A revert of this CL has been created in https://codereview.chromium.org/274453011/ by tapted@chromium.org. The reason for ...
6 years, 7 months ago (2014-05-08 05:57:19 UTC) #15
tapted
https://codereview.chromium.org/266033002/diff/70001/components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc File components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc (right): https://codereview.chromium.org/266033002/diff/70001/components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc#newcode305 components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc:305: DataReductionProxySettings::GetDataReductionProxies(); did a double-take due since data_reduction_proxy_settings.cc didn't actually ...
6 years, 7 months ago (2014-05-08 06:01:25 UTC) #16
bengr
The CQ bit was checked by bengr@chromium.org
6 years, 7 months ago (2014-05-08 18:00:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bengr@chromium.org/266033002/90001
6 years, 7 months ago (2014-05-08 18:06:19 UTC) #18
bengr
The CQ bit was unchecked by bengr@chromium.org
6 years, 7 months ago (2014-05-08 18:32:48 UTC) #19
bengr
The CQ bit was checked by bengr@chromium.org
6 years, 7 months ago (2014-05-08 18:33:27 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bengr@chromium.org/266033002/90001
6 years, 7 months ago (2014-05-08 18:40:53 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 23:08:51 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 23:34:02 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/140649)
6 years, 7 months ago (2014-05-08 23:34:02 UTC) #24
bengr
The CQ bit was checked by bengr@chromium.org
6 years, 7 months ago (2014-05-10 01:55:19 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bengr@chromium.org/266033002/170001
6 years, 7 months ago (2014-05-10 01:56:25 UTC) #26
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 05:17:18 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 05:20:31 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/66998)
6 years, 7 months ago (2014-05-10 05:20:33 UTC) #29
bengr
The CQ bit was checked by bengr@chromium.org
6 years, 7 months ago (2014-05-10 05:27:21 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bengr@chromium.org/266033002/170001
6 years, 7 months ago (2014-05-10 05:30:33 UTC) #31
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 06:24:01 UTC) #32
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 01:09:37 UTC) #33
Message was sent while issue was closed.
Change committed as 269670

Powered by Google App Engine
This is Rietveld 408576698