components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h - Issue 266033002: Collect data reduction proxy UMA on all platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h

Issue 266033002: Collect data reduction proxy UMA on all platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove ifdef from HttpResponseHeaders::IsDataReductionProxyResponse() Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/page_load_histograms.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h b/components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h

index 0e4cab215a81fa9743f37652f28dbd74474af5a8..b308742aa3426fa6ece7a7f5a93dbb9322c2f86b 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h

@@ -39,8 +39,6 @@ int64 GetAdjustedOriginalContentLength(

int64 original_content_length,

int64 received_content_length);

-#if defined(OS_ANDROID) || defined(OS_IOS)

-// TODO(bengr): Remove platform-specific ifdefs.

// This is only exposed for testing. It is normally called by

// UpdateContentLengthPrefs.

void UpdateContentLengthPrefsForDataReductionProxy(

@@ -49,7 +47,6 @@ void UpdateContentLengthPrefsForDataReductionProxy(

bool with_data_reduction_proxy_enabled,

DataReductionProxyRequestType request_type,

base::Time now, PrefService* prefs);

-#endif

// Records daily data savings statistics to prefs and reports data savings UMA.

void UpdateContentLengthPrefs(

« no previous file with comments | « chrome/renderer/page_load_histograms.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc » ('j') | no next file with comments »