Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/renderer/page_load_histograms.cc

Issue 266033002: Collect data reduction proxy UMA on all platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove ifdef from HttpResponseHeaders::IsDataReductionProxyResponse() Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_histograms.cc
diff --git a/chrome/renderer/page_load_histograms.cc b/chrome/renderer/page_load_histograms.cc
index 87a92526bed54de09ace2ef418ec13d9b451d7b8..1b60fac154c01665200cb16cdf489b1338ec271b 100644
--- a/chrome/renderer/page_load_histograms.cc
+++ b/chrome/renderer/page_load_histograms.cc
@@ -24,6 +24,7 @@
#include "content/public/renderer/render_view.h"
#include "extensions/common/url_pattern.h"
#include "net/base/url_util.h"
+#include "net/http/http_response_headers.h"
#include "third_party/WebKit/public/platform/WebURLRequest.h"
#include "third_party/WebKit/public/platform/WebURLResponse.h"
#include "third_party/WebKit/public/web/WebDocument.h"
@@ -32,10 +33,6 @@
#include "third_party/WebKit/public/web/WebView.h"
#include "url/gurl.h"
-#if defined(SPDY_PROXY_AUTH_ORIGIN)
-#include "net/http/http_response_headers.h"
-#endif
-
using blink::WebDataSource;
using blink::WebFrame;
using blink::WebPerformance;
@@ -199,7 +196,6 @@ bool ViaHeaderContains(WebFrame* frame, const std::string& via_value) {
// TODO(bengr): Plumb the hostname of the proxy and check if it matches
// |SPDY_PROXY_AUTH_ORIGIN|.
bool DataReductionProxyWasUsed(WebFrame* frame) {
-#if defined(SPDY_PROXY_AUTH_ORIGIN)
DocumentState* document_state =
DocumentState::FromDataSource(frame->dataSource());
if (!document_state->was_fetched_via_proxy())
@@ -216,9 +212,6 @@ bool DataReductionProxyWasUsed(WebFrame* frame) {
scoped_refptr<net::HttpResponseHeaders> response_headers(
new net::HttpResponseHeaders(headers));
return response_headers->IsDataReductionProxyResponse();
-#else
- return false;
-#endif
}
// Returns true if the provided URL is a referrer string that came from
« no previous file with comments | « chrome/browser/net/chrome_network_delegate.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698