Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2660163002: Unflag promise-based RTCPeerConnection.getStats. (Closed)

Created:
3 years, 10 months ago by hbos_chromium
Modified:
3 years, 10 months ago
Reviewers:
Guido Urdaneta, foolip
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update virtual/stable/webexposed/global-interface-listing-expected.txt #

Patch Set 3 : mac's global-interface-listing-expected.txt #

Messages

Total messages: 21 (16 generated)
hbos_chromium
Please take a look, guidou and foolip.
3 years, 10 months ago (2017-01-30 14:23:45 UTC) #7
foolip
third_party/WebKit/ lgtm
3 years, 10 months ago (2017-01-30 15:10:20 UTC) #8
Guido Urdaneta
lgtm, but look at the platform-specific global-interface-listing files.
3 years, 10 months ago (2017-01-30 19:35:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660163002/60001
3 years, 10 months ago (2017-01-31 10:50:35 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 12:27:01 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/68f8e256dc7c7369127bd345100b...

Powered by Google App Engine
This is Rietveld 408576698