third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl - Issue 2660163002: Unflag promise-based RTCPeerConnection.getStats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

Issue 2660163002: Unflag promise-based RTCPeerConnection.getStats. (Closed)

Patch Set: mac's global-interface-listing-expected.txt Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt ('k') | third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

index 81853fe4a77919ee8256ffbf6fdf8b24bae260f4..20ef352b02c46b5a09edcf4b773a4e9152af4a71 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

@@ -110,7 +110,7 @@ enum RTCIceConnectionState {

// TODO(hbos): The spec has an optional |selector| argument that is not

// supported yet. There is a discussion about what to do with it (clarify

// spec, remove it or change it?): https://github.com/w3c/webrtc-stats/issues/116

- [CallWith=ScriptState, RuntimeEnabled=RTCPeerConnectionNewGetStats] Promise<RTCStatsReport> getStats();

+ [CallWith=ScriptState] Promise<RTCStatsReport> getStats();

// https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api

// TODO(guidou): The label argument should have [TreatNullAs=EmptyString]