Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 2660003003: Add MediaError.message (Closed)
Patch Set: --flakiness by using std::map, update virtual/stable/[win,mac] global interface listing too Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index 366ada9eddc7407a641a1b1dc0c809181f4426dc..a459b08e55bd3795ec2e229eda63fd858095b64a 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -777,9 +777,10 @@ WebMediaPlayer::ReadyState WebMediaPlayerImpl::GetReadyState() const {
return ready_state_;
}
-blink::WebString WebMediaPlayerImpl::GetErrorMessage() {
+std::map<std::string, std::vector<std::string>>
jochen (gone - plz use gerrit) 2017/04/12 09:16:42 hum, it looks like you really want a base::Value o
wolenetz 2017/04/13 23:59:10 I switched back to just blink::WebString. JSON-enc
+WebMediaPlayerImpl::GetErrorMessages() const {
DCHECK(main_task_runner_->BelongsToCurrentThread());
- return blink::WebString::FromUTF8(media_log_->GetLastErrorMessage());
+ return media_log_->GetErrorMessages();
}
blink::WebTimeRanges WebMediaPlayerImpl::Buffered() const {

Powered by Google App Engine
This is Rietveld 408576698