media/blink/webmediaplayer_impl.h - Issue 2660003003: Add MediaError.message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 2660003003: Add MediaError.message (Closed)

Patch Set: --flakiness by using std::map, update virtual/stable/[win,mac] global interface listing too Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/blink/webmediaplayer_impl.h

diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h

index 29863b0c00dfacb973658ada52db1d414d40fd46..9a3ab4adf10cee7061d1d12e222b1bfa3d138957 100644

--- a/media/blink/webmediaplayer_impl.h

+++ b/media/blink/webmediaplayer_impl.h

@@ -158,7 +158,8 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl

blink::WebMediaPlayer::NetworkState GetNetworkState() const override;

blink::WebMediaPlayer::ReadyState GetReadyState() const override;

- blink::WebString GetErrorMessage() override;

+ std::map<std::string, std::vector<std::string>> GetErrorMessages()

+ const override;

bool DidLoadingProgress() override;

bool HasSingleSecurityOrigin() const override;