Add MediaError.message

media/blink/webmediaplayer_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/webmediaplayer_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <limits>
 #include <string>
@@ skipping 759 matching lines @@
 WebMediaPlayer::NetworkState WebMediaPlayerImpl::GetNetworkState() const {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
   return network_state_;
 }
 
 WebMediaPlayer::ReadyState WebMediaPlayerImpl::GetReadyState() const {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
   return ready_state_;
 }
 
-blink::WebString WebMediaPlayerImpl::GetErrorMessage() {
+std::map<std::string, std::vector<std::string>>

[jochen (gone - plz use gerrit), 2017/04/12 09:16:42]

hum, it looks like you really want a base::Value or something here, no?

[wolenetz, 2017/04/13 23:59:10]

I switched back to just blink::WebString. JSON-encoding the error message was
contentious (see other threads on this review).

+WebMediaPlayerImpl::GetErrorMessages() const {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
-  return blink::WebString::FromUTF8(media_log_->GetLastErrorMessage());
+  return media_log_->GetErrorMessages();
 }
 
 blink::WebTimeRanges WebMediaPlayerImpl::Buffered() const {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
 
   Ranges<base::TimeDelta> buffered_time_ranges =
       pipeline_controller_.GetBufferedTimeRanges();
 
   const base::TimeDelta duration = GetPipelineMediaDuration();
   if (duration != kInfiniteDuration) {
@@ skipping 1545 matching lines @@
 
 void WebMediaPlayerImpl::RecordUnderflowDuration(base::TimeDelta duration) {
   DCHECK(data_source_ || chunk_demuxer_);
   if (data_source_)
     UMA_HISTOGRAM_TIMES("Media.UnderflowDuration", duration);
   else
     UMA_HISTOGRAM_TIMES("Media.UnderflowDuration.MSE", duration);
 }
 
 }  // namespace media