Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2659983002: Convert ManagePasswordsUIController to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ManagePasswordsUIController to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2659983002 Cr-Commit-Position: refs/heads/master@{#446997} Committed: https://chromium.googlesource.com/chromium/src/+/8a45849750a8bdffd8a47d76c52af3cdf3e834b6

Patch Set 1 #

Patch Set 2 : fix test #

Patch Set 3 : fix test #

Patch Set 4 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M chrome/browser/ui/passwords/manage_passwords_ui_controller.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc View 1 2 3 5 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 32 (28 generated)
jam
3 years, 10 months ago (2017-01-28 04:35:18 UTC) #26
vasilii
lgtm
3 years, 10 months ago (2017-01-30 12:30:46 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659983002/80001
3 years, 10 months ago (2017-01-30 15:52:26 UTC) #29
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 16:36:23 UTC) #32
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8a45849750a8bdffd8a47d76c52a...

Powered by Google App Engine
This is Rietveld 408576698