chrome/browser/ui/passwords/manage_passwords_ui_controller.h - Issue 2659983002: Convert ManagePasswordsUIController to use the new navigation callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 2659983002: Convert ManagePasswordsUIController to use the new navigation callbacks. (Closed)

Patch Set: fix tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

index 876212a8f8df389a1218fc7ff02b2b9289168485..80b3f829f9fa65cd263837d3827c93f7b126d783 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h

@@ -140,9 +140,8 @@ class ManagePasswordsUIController

}

// content::WebContentsObserver:

- void DidNavigateMainFrame(

- const content::LoadCommittedDetails& details,

- const content::FrameNavigateParams& params) override;

+ void DidFinishNavigation(

+ content::NavigationHandle* navigation_handle) override;

void WasHidden() override;

private:

« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | no next file with comments »