Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2659913002: V8 Inspector: complete migration to the standard message level enum. (Closed)

Created:
3 years, 10 months ago by pfeldman
Modified:
3 years, 10 months ago
Reviewers:
dgozman, alph
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, Paweł Hajdan Jr.
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

V8 Inspector: complete migration to the standard message level enum. BUG=chromium:682521 Review-Url: https://codereview.chromium.org/2659913002 Cr-Commit-Position: refs/heads/master@{#42747} Committed: https://chromium.googlesource.com/v8/v8/+/82ef9f75e343bb49f99a6f39f8c280bf3ef42b64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M include/v8-inspector.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/inspector/v8-console-message.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
pfeldman
3 years, 10 months ago (2017-01-27 16:45:29 UTC) #4
alph
lgtm
3 years, 10 months ago (2017-01-27 18:31:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659913002/1
3 years, 10 months ago (2017-01-27 18:47:33 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 18:49:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/82ef9f75e343bb49f99a6f39f8c280bf3ef...

Powered by Google App Engine
This is Rietveld 408576698