Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: include/v8-inspector.h

Issue 2659913002: V8 Inspector: complete migration to the standard message level enum. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/v8-console-message.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-inspector.h
diff --git a/include/v8-inspector.h b/include/v8-inspector.h
index adb097f9c97d5752cac57d6940a00fcd0b8448b7..cf1a5fd551f2332e2f2186b50e4b57751396a972 100644
--- a/include/v8-inspector.h
+++ b/include/v8-inspector.h
@@ -156,8 +156,6 @@ class V8_EXPORT V8InspectorSession {
virtual void releaseObjectGroup(const StringView&) = 0;
};
-enum class V8ConsoleAPIType { kClear, kDebug, kLog, kInfo, kWarning, kError };
-
class V8_EXPORT V8InspectorClient {
public:
virtual ~V8InspectorClient() {}
@@ -189,11 +187,6 @@ class V8_EXPORT V8InspectorClient {
virtual void installAdditionalCommandLineAPI(v8::Local<v8::Context>,
v8::Local<v8::Object>) {}
- // Deprecated, to be replaced with v8::Isolate::MessageErrorLevel version.
- virtual void consoleAPIMessage(int contextGroupId, V8ConsoleAPIType,
- const StringView& message,
- const StringView& url, unsigned lineNumber,
- unsigned columnNumber, V8StackTrace*) {}
virtual void consoleAPIMessage(int contextGroupId,
v8::Isolate::MessageErrorLevel level,
const StringView& message,
« no previous file with comments | « no previous file | src/inspector/v8-console-message.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698