Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2659773003: Convert ExtensionViewGuest to use the new navigation callbacks. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ExtensionViewGuest to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2659773003 Cr-Commit-Position: refs/heads/master@{#446514} Committed: https://chromium.googlesource.com/chromium/src/+/c80c4a6801f438c230a65c6d81d65457efc1e431

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -21 lines) Patch
M extensions/browser/guest_view/extension_view/extension_view_guest.h View 1 chunk +1 line, -6 lines 0 comments Download
M extensions/browser/guest_view/extension_view/extension_view_guest.cc View 3 chunks +5 lines, -15 lines 2 comments Download

Messages

Total messages: 15 (9 generated)
jam
3 years, 11 months ago (2017-01-26 23:34:47 UTC) #5
Fady Samuel
https://codereview.chromium.org/2659773003/diff/1/extensions/browser/guest_view/extension_view/extension_view_guest.cc File extensions/browser/guest_view/extension_view/extension_view_guest.cc (left): https://codereview.chromium.org/2659773003/diff/1/extensions/browser/guest_view/extension_view/extension_view_guest.cc#oldcode138 extensions/browser/guest_view/extension_view/extension_view_guest.cc:138: if (attached() && !url::IsSameOriginWith(params.url, url_)) { Do we want ...
3 years, 11 months ago (2017-01-26 23:39:07 UTC) #6
jam
https://codereview.chromium.org/2659773003/diff/1/extensions/browser/guest_view/extension_view/extension_view_guest.cc File extensions/browser/guest_view/extension_view/extension_view_guest.cc (left): https://codereview.chromium.org/2659773003/diff/1/extensions/browser/guest_view/extension_view/extension_view_guest.cc#oldcode138 extensions/browser/guest_view/extension_view/extension_view_guest.cc:138: if (attached() && !url::IsSameOriginWith(params.url, url_)) { On 2017/01/26 23:39:07, ...
3 years, 11 months ago (2017-01-26 23:40:20 UTC) #7
Fady Samuel
lgtm
3 years, 11 months ago (2017-01-26 23:42:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659773003/1
3 years, 11 months ago (2017-01-27 00:38:43 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 01:11:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c80c4a6801f438c230a65c6d81d6...

Powered by Google App Engine
This is Rietveld 408576698