Convert ExtensionViewGuest to use the new navigation callbacks.

Convert ExtensionViewGuest to use the new navigation callbacks.

BUG=682002
Review-Url: https://codereview.chromium.org/2659773003
Cr-Commit-Position: refs/heads/master@{#446514}
Committed: https://chromium.googlesource.com/chromium/src/+/c80c4a6801f438c230a65c6d81d65457efc1e431

[jam, 2017-01-26 23:13:07]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-01-26 23:13:13]

Description was changed from

==========
Convert ExtensionViewGuest to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert ExtensionViewGuest to use the new navigation callbacks.

BUG=682002
==========

[jam, 2017-01-26 23:13:13]

jam@chromium.org changed reviewers:
+ fsamuel@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:13:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-01-26 23:39:07]

https://codereview.chromium.org/2659773003/diff/1/extensions/browser/guest_vi...
File extensions/browser/guest_view/extension_view/extension_view_guest.cc
(left):

https://codereview.chromium.org/2659773003/diff/1/extensions/browser/guest_vi...
extensions/browser/guest_view/extension_view/extension_view_guest.cc:138: if
(attached() && !url::IsSameOriginWith(params.url, url_)) {
Do we want to allow navigating to a different origin now?

[jam, 2017-01-26 23:40:20]

https://codereview.chromium.org/2659773003/diff/1/extensions/browser/guest_vi...
File extensions/browser/guest_view/extension_view/extension_view_guest.cc
(left):

https://codereview.chromium.org/2659773003/diff/1/extensions/browser/guest_vi...
extensions/browser/guest_view/extension_view/extension_view_guest.cc:138: if
(attached() && !url::IsSameOriginWith(params.url, url_)) {
On 2017/01/26 23:39:07, Fady Samuel wrote:
> Do we want to allow navigating to a different origin now?

well before there were two different navigation callbacks being listened to, and
this second one checked that the URL matched between them (since url_ is set in
the first one). now that we only have one navigation callback, it doesn't make
sense to check I thought.

[Fady Samuel, 2017-01-26 23:42:21]

lgtm

[commit-bot: I haz the power, 2017-01-27 00:11:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:11:26]

Dry run: This issue passed the CQ dry run.

[jam, 2017-01-27 00:35:56]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-01-27 00:38:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 01:10:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485477356758820, "parent_rev":
"202f302518b115689972a7155b5f97562be7a17b", "commit_rev":
"c80c4a6801f438c230a65c6d81d65457efc1e431"}

[commit-bot: I haz the power, 2017-01-27 01:11:05]

Description was changed from

==========
Convert ExtensionViewGuest to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert ExtensionViewGuest to use the new navigation callbacks.

BUG=682002

Review-Url: https://codereview.chromium.org/2659773003
Cr-Commit-Position: refs/heads/master@{#446514}
Committed:
https://chromium.googlesource.com/chromium/src/+/c80c4a6801f438c230a65c6d81d6...
==========

[commit-bot: I haz the power, 2017-01-27 01:11:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c80c4a6801f438c230a65c6d81d6...