Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: extensions/browser/guest_view/extension_view/extension_view_guest.h

Issue 2659773003: Convert ExtensionViewGuest to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/extension_view/extension_view_guest.h
diff --git a/extensions/browser/guest_view/extension_view/extension_view_guest.h b/extensions/browser/guest_view/extension_view/extension_view_guest.h
index d947b240cc7e1ece15ab1e6ef9a109dd98ad4d8b..fc244e4817882d51be5d2415f35c852feac4f2a4 100644
--- a/extensions/browser/guest_view/extension_view/extension_view_guest.h
+++ b/extensions/browser/guest_view/extension_view/extension_view_guest.h
@@ -37,12 +37,7 @@ class ExtensionViewGuest
int GetTaskPrefix() const final;
// content::WebContentsObserver implementation.
- void DidCommitProvisionalLoadForFrame(
- content::RenderFrameHost* render_frame_host,
- const GURL& url,
- ui::PageTransition transition_type) final;
- void DidNavigateMainFrame(const content::LoadCommittedDetails& details,
- const content::FrameNavigateParams& params) final;
+ void DidFinishNavigation(content::NavigationHandle* navigation_handle) final;
// Applies attributes to the extensionview.
void ApplyAttributes(const base::DictionaryValue& params);

Powered by Google App Engine
This is Rietveld 408576698