Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2658573008: Convert the array iterator protector to a PropertyCell. (Closed)

Created:
3 years, 10 months ago by petermarshall
Modified:
3 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
Hannes Payer (out of office), ulan, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Convert the array iterator protector to a PropertyCell. We need it to be a PropertyCell so that we can list it as a dependency for optimised code. Also drive-by clean up some variable names in src/isolate-inl.h. BUG=v8:5895 Review-Url: https://codereview.chromium.org/2658573008 Cr-Commit-Position: refs/heads/master@{#42764} Committed: https://chromium.googlesource.com/v8/v8/+/ccf428bb0473cf894bf1adae286917ba6156d376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -23 lines) Patch
M src/builtins/arm/builtins-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/x87/builtins-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/isolate-inl.h View 1 chunk +7 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (9 generated)
Michael Starzinger
LGTM.
3 years, 10 months ago (2017-01-30 09:24:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658573008/1
3 years, 10 months ago (2017-01-30 09:25:00 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 09:55:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ccf428bb0473cf894bf1adae286917ba615...

Powered by Google App Engine
This is Rietveld 408576698