Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 2659603003: Adapt use-site to new BoilerplateDescription. (Closed)

Created:
3 years, 10 months ago by Michael Starzinger
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer, marja
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adapt use-site to new BoilerplateDescription. This makes sure all use-site of {ObjectLiteral::constant_properties} are adapted to use the correct {BoilerplateDescription} type instead of just the {FixedArray} base type. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2659603003 Cr-Commit-Position: refs/heads/master@{#42738} Committed: https://chromium.googlesource.com/v8/v8/+/9ea3fe0bb398b4442753f30f733b628712f52adf

Patch Set 1 #

Patch Set 2 : One more use-site. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M src/ast/ast.h View 3 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +4 lines, -3 lines 1 comment Download
M src/compiler/js-operator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-operator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
Michael Starzinger
https://codereview.chromium.org/2659603003/diff/20001/src/compiler/bytecode-graph-builder.cc File src/compiler/bytecode-graph-builder.cc (right): https://codereview.chromium.org/2659603003/diff/20001/src/compiler/bytecode-graph-builder.cc#newcode1225 src/compiler/bytecode-graph-builder.cc:1225: int number_of_properties = constant_properties->size(); This is the only note-worthy ...
3 years, 10 months ago (2017-01-27 12:11:31 UTC) #3
Michael Starzinger
Benedikt: PTAL. Marja: FYI.
3 years, 10 months ago (2017-01-27 12:14:33 UTC) #6
Benedikt Meurer
LGTM
3 years, 10 months ago (2017-01-27 12:15:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659603003/20001
3 years, 10 months ago (2017-01-27 12:58:59 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 13:02:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/9ea3fe0bb398b4442753f30f733b628712f...

Powered by Google App Engine
This is Rietveld 408576698