Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Issue 2659293002: Disable assertion failing on Win7 test dbg builder. (Closed)

Created:
3 years, 10 months ago by Bryan McQuade
Modified:
3 years, 10 months ago
Reviewers:
Charlie Harrison
CC:
asvitkine+watch_chromium.org, chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable assertion failing on Win7 test dbg builder. BUG=686590 TBR=csharrison Review-Url: https://codereview.chromium.org/2659293002 Cr-Commit-Position: refs/heads/master@{#446948} Committed: https://chromium.googlesource.com/chromium/src/+/5a006f6773bd972507244e9ad74dab7471bff6b7

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659293002/20001
3 years, 10 months ago (2017-01-29 23:17:35 UTC) #10
Charlie Harrison
LGTM
3 years, 10 months ago (2017-01-29 23:20:57 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-29 23:21:40 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5a006f6773bd972507244e9ad74d...

Powered by Google App Engine
This is Rietveld 408576698