Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2428)

Unified Diff: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc

Issue 2659293002: Disable assertion failing on Win7 test dbg builder. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc
index 4b8161f146f720691d29f8e2e2198dacca24e72d..da4847abd92494766062c61e836dade4e1c6eea7 100644
--- a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc
@@ -158,8 +158,10 @@ TEST_F(ServiceWorkerPageLoadMetricsObserverTest, WithServiceWorkerBackground) {
histogram_tester().ExpectTotalCount(
internal::kHistogramServiceWorkerDomContentLoaded, 0);
histogram_tester().ExpectTotalCount(internal::kHistogramServiceWorkerLoad, 0);
- histogram_tester().ExpectTotalCount(
- internal::kBackgroundHistogramServiceWorkerParseStart, 1);
+ // TODO(crbug.com/686590): The following expectation fails on Win7 Tests
+ // (dbg)(1) builder, so is disabled for the time being.
+ // histogram_tester().ExpectTotalCount(
+ // internal::kBackgroundHistogramServiceWorkerParseStart, 1);
AssertNoInboxHistogramsLogged();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698