Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2659133002: Remove /resources/ from a vector_icon.h include to fix Google Chrome Mac compile (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove /resources/ from a vector_icon.h include to fix Google Chrome Mac compile TBR=estade@chromium.org BUG=684911 NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2659133002 Cr-Commit-Position: refs/heads/master@{#446785} Committed: https://chromium.googlesource.com/chromium/src/+/bc2e9b86da06f3f673ff175001e8b886500102b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/style/platform_style_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
Dan Beam
3 years, 10 months ago (2017-01-27 22:04:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659133002/1
3 years, 10 months ago (2017-01-27 22:06:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/bc2e9b86da06f3f673ff175001e8b886500102b2
3 years, 10 months ago (2017-01-27 22:07:48 UTC) #8
mdjones
3 years, 10 months ago (2017-01-27 22:15:21 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2659993002/ by mdjones@chromium.org.

The reason for reverting is: Compile error on GPU Mac Builder:
../../ui/views/style/platform_style_mac.mm:15:10: fatal error:
'ui/views/vector_icons/vector_icons.h' file not found.

Powered by Google App Engine
This is Rietveld 408576698