Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2656983004: Actually fix Google Chrome Mac compile failure from vector_icon.h #include (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Actually fix Google Chrome Mac compile failure from vector_icon.h #include TBR=estade@chromium.org BUG=684911 Review-Url: https://codereview.chromium.org/2656983004 . Cr-Commit-Position: refs/heads/master@{#446788} Committed: https://chromium.googlesource.com/chromium/src/+/5b207820938548653d3b8f0b539affa1bb14436f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/style/platform_style_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2659133002 Patch 1

Messages

Total messages: 4 (1 generated)
Dan Beam
whoops
3 years, 10 months ago (2017-01-27 22:14:28 UTC) #1
Dan Beam
Committed patchset #1 (id:1) manually as 5b207820938548653d3b8f0b539affa1bb14436f.
3 years, 10 months ago (2017-01-27 22:15:53 UTC) #3
Evan Stade
3 years, 10 months ago (2017-01-27 23:34:02 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698