Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2658953004: Rename EOverflowAnchor values with k prefix. (Closed)

Created:
3 years, 10 months ago by shend
Modified:
3 years, 10 months ago
Reviewers:
sashab, Bugs Nash
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename EOverflowAnchor values with k prefix. Rename the values of the EOverflowAnchor enum with the k prefix to match the style generated by make_computed_style_base.py, which is in line with the Blink rename to match Chromium style. This is prework for generating EOverflowAnchor. BUG=684966 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2658953004 Cr-Commit-Position: refs/heads/master@{#446916} Committed: https://chromium.googlesource.com/chromium/src/+/4a47e08858ad7ede6ea59d80dd87ff94fb7ffab4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (9 generated)
shend
Hey Bugs PTAL. Just a rename patch :)
3 years, 10 months ago (2017-01-27 03:31:56 UTC) #3
Bugs Nash
lgtm
3 years, 10 months ago (2017-01-27 03:50:24 UTC) #4
shend
Sasha PTAL :)
3 years, 10 months ago (2017-01-27 03:51:40 UTC) #6
shend
Sasha PTAL :)
3 years, 10 months ago (2017-01-27 03:51:40 UTC) #7
sashab
LGTM also add to CL description something like: Adding the 'k' enum prefix is also ...
3 years, 10 months ago (2017-01-27 22:00:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658953004/1
3 years, 10 months ago (2017-01-28 02:05:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/311808) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 10 months ago (2017-01-28 02:08:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658953004/1
3 years, 10 months ago (2017-01-28 08:15:14 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 08:20:40 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4a47e08858ad7ede6ea59d80dd87...

Powered by Google App Engine
This is Rietveld 408576698