Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2657073003: Moved overflow-anchor property to be generated in ComputedStyleBase. (Closed)

Created:
3 years, 10 months ago by shend
Modified:
3 years, 10 months ago
Reviewers:
nainar, sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis, napper
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved overflow-anchor property to be generated in ComputedStyleBase. Move the property overflow-anchor and its enum, EOverflowAnchor, to be generated in ComputedStyleBase. Also moved getter / setter / initial value methods to be generated in ComputedStyleBase. BUG=628043 Review-Url: https://codereview.chromium.org/2657073003 Cr-Commit-Position: refs/heads/master@{#447420} Committed: https://chromium.googlesource.com/chromium/src/+/369872a93aee896cb702994b7f3558ccd91ed02b

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -21 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 4 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 28 (20 generated)
shend
Hey Naina, PTAL :)
3 years, 10 months ago (2017-01-27 05:17:30 UTC) #2
nainar
lgtm
3 years, 10 months ago (2017-01-27 05:18:28 UTC) #3
shend
hi Sasha PTAL
3 years, 10 months ago (2017-01-27 05:21:41 UTC) #5
sashab
LGTM nice work!! +napper fyi these are happening https://codereview.chromium.org/2657073003/diff/1/third_party/WebKit/Source/core/css/CSSProperties.json5 File third_party/WebKit/Source/core/css/CSSProperties.json5 (right): https://codereview.chromium.org/2657073003/diff/1/third_party/WebKit/Source/core/css/CSSProperties.json5#newcode1277 third_party/WebKit/Source/core/css/CSSProperties.json5:1277: ], ...
3 years, 10 months ago (2017-01-27 21:58:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657073003/20001
3 years, 10 months ago (2017-01-29 22:43:06 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/145774)
3 years, 10 months ago (2017-01-29 23:01:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657073003/20001
3 years, 10 months ago (2017-02-01 01:55:36 UTC) #25
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 02:32:21 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/369872a93aee896cb702994b7f35...

Powered by Google App Engine
This is Rietveld 408576698