VM: Remove unused optimization of merging of sin/cos.

VM: Remove unused optimization of merging of sin/cos.

It was only implemented on ia32/x64, and has been disabled
for a long time (broken on Windows).

Fixes #22504.

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/9ea0dbcab13c1cb3c13847ada6ff0aab3ad15df1

[Florian Schneider, 2017-01-26 01:27:46]

fschneider@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2017-01-26 13:57:27]

johnmccutchan@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2017-01-26 13:57:27]

LGTM.

Note that this did provide a measurable (single digit %) performance increase in
box2d.

John

[Florian Schneider, 2017-01-26 15:33:27]

On 2017/01/26 13:57:27, Cutch wrote:
> LGTM.
> 
> Note that this did provide a measurable (single digit %) performance increase
in
> box2d.
> 
> John

I see. Right now it's unused code.

I'd rather bring it back fixed and on all platforms than leave in the current
code which is disabled and untested for a long time. (assuming we can get a
similar speedup on ARM/ARM64)

[Cutch, 2017-01-26 15:39:03]

On 2017/01/26 15:33:27, Florian Schneider wrote:
> On 2017/01/26 13:57:27, Cutch wrote:
> > LGTM.
> > 
> > Note that this did provide a measurable (single digit %) performance
increase
> in
> > box2d.
> > 
> > John
> 
> I see. Right now it's unused code.
> 
> I'd rather bring it back fixed and on all platforms than leave in the current
> code which is disabled and untested for a long time. (assuming we can get a
> similar speedup on ARM/ARM64)

I'm also in favour of removing it, I just wanted to note that at one point in
time it offered a speedup.

[Florian Schneider, 2017-01-26 20:43:00]

Description was changed from

==========
VM: Remove unused optimization of merging of sin/cos.

It was only implemented on ia32/x64, and has been disabled
for a long time (broken on Windows).

Fixes #22504.
==========

to

==========
VM: Remove unused optimization of merging of sin/cos.

It was only implemented on ia32/x64, and has been disabled
for a long time (broken on Windows).

Fixes #22504.

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9ea0dbcab13c1cb3c13847ada6ff0aab3ad15df1
==========

[Florian Schneider, 2017-01-26 20:43:01]

Committed patchset #2 (id:20001) manually as
9ea0dbcab13c1cb3c13847ada6ff0aab3ad15df1 (presubmit successful).