Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 2658733002: VM: Remove unused optimization of merging of sin/cos. (Closed)
Patch Set: Remove now unused representation Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 2 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
3 // for details. All rights reserved. Use of this source code is governed by a 3 // for details. All rights reserved. Use of this source code is governed by a
4 // BSD-style license that can be found in the LICENSE file. 4 // BSD-style license that can be found in the LICENSE file.
5 5
6 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 6 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
7 #if defined(TARGET_ARCH_ARM) 7 #if defined(TARGET_ARCH_ARM)
8 8
9 #include "vm/intermediate_language.h" 9 #include "vm/intermediate_language.h"
10 10
(...skipping 6215 matching lines...) Expand 10 before | Expand all | Expand 10 after
6226 __ cmp(result_mod, Operand(0)); 6226 __ cmp(result_mod, Operand(0));
6227 __ b(&done, GE); 6227 __ b(&done, GE);
6228 // Result is negative, adjust it. 6228 // Result is negative, adjust it.
6229 __ cmp(right, Operand(0)); 6229 __ cmp(right, Operand(0));
6230 __ sub(result_mod, result_mod, Operand(right), LT); 6230 __ sub(result_mod, result_mod, Operand(right), LT);
6231 __ add(result_mod, result_mod, Operand(right), GE); 6231 __ add(result_mod, result_mod, Operand(right), GE);
6232 __ Bind(&done); 6232 __ Bind(&done);
6233 6233
6234 return; 6234 return;
6235 } 6235 }
6236 if (kind() == MergedMathInstr::kSinCos) {
6237 UNIMPLEMENTED();
6238 }
6239 UNIMPLEMENTED(); 6236 UNIMPLEMENTED();
6240 } 6237 }
6241 6238
6242 6239
6243 LocationSummary* PolymorphicInstanceCallInstr::MakeLocationSummary( 6240 LocationSummary* PolymorphicInstanceCallInstr::MakeLocationSummary(
6244 Zone* zone, 6241 Zone* zone,
6245 bool opt) const { 6242 bool opt) const {
6246 return MakeCallSummary(zone); 6243 return MakeCallSummary(zone);
6247 } 6244 }
6248 6245
(...skipping 978 matching lines...) Expand 10 before | Expand all | Expand 10 after
7227 compiler->GenerateRuntimeCall(TokenPosition::kNoSource, deopt_id(), 7224 compiler->GenerateRuntimeCall(TokenPosition::kNoSource, deopt_id(),
7228 kGrowRegExpStackRuntimeEntry, 1, locs()); 7225 kGrowRegExpStackRuntimeEntry, 1, locs());
7229 __ Drop(1); 7226 __ Drop(1);
7230 __ Pop(result); 7227 __ Pop(result);
7231 } 7228 }
7232 7229
7233 7230
7234 } // namespace dart 7231 } // namespace dart
7235 7232
7236 #endif // defined TARGET_ARCH_ARM 7233 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698