Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: runtime/vm/intermediate_language.h

Issue 2658733002: VM: Remove unused optimization of merging of sin/cos. (Closed)
Patch Set: Remove now unused representation Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/il_printer.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index 2543954c0900a84f7ee62b8f4d3bb48bb6d08d96..8359174d661d6fa662f1ad0b7708b4655b7ffa1f 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -1624,11 +1624,9 @@ class Definition : public Instruction {
void ClearSSATempIndex() { ssa_temp_index_ = -1; }
bool HasPairRepresentation() const {
#if defined(TARGET_ARCH_X64)
- return (representation() == kPairOfTagged) ||
- (representation() == kPairOfUnboxedDouble);
+ return representation() == kPairOfTagged;
#else
return (representation() == kPairOfTagged) ||
- (representation() == kPairOfUnboxedDouble) ||
(representation() == kUnboxedMint);
#endif
}
@@ -7392,8 +7390,6 @@ class ExtractNthOutputInstr : public TemplateDefinition<1, NoThrow, Pure> {
ASSERT(idx == 0);
if (representation() == kTagged) {
return kPairOfTagged;
- } else if (representation() == kUnboxedDouble) {
- return kPairOfUnboxedDouble;
}
UNREACHABLE();
return definition_rep_;
@@ -7419,7 +7415,6 @@ class MergedMathInstr : public PureDefinition {
public:
enum Kind {
kTruncDivMod,
- kSinCos,
};
MergedMathInstr(ZoneGrowableArray<Value*>* inputs,
@@ -7429,8 +7424,6 @@ class MergedMathInstr : public PureDefinition {
static intptr_t InputCountFor(MergedMathInstr::Kind kind) {
if (kind == kTruncDivMod) {
return 2;
- } else if (kind == kSinCos) {
- return 1;
} else {
UNIMPLEMENTED();
return -1;
@@ -7451,8 +7444,6 @@ class MergedMathInstr : public PureDefinition {
virtual bool CanDeoptimize() const {
if (kind_ == kTruncDivMod) {
return true;
- } else if (kind_ == kSinCos) {
- return false;
} else {
UNIMPLEMENTED();
return false;
@@ -7462,8 +7453,6 @@ class MergedMathInstr : public PureDefinition {
virtual Representation representation() const {
if (kind_ == kTruncDivMod) {
return kPairOfTagged;
- } else if (kind_ == kSinCos) {
- return kPairOfUnboxedDouble;
} else {
UNIMPLEMENTED();
return kTagged;
@@ -7474,8 +7463,6 @@ class MergedMathInstr : public PureDefinition {
ASSERT((0 <= idx) && (idx < InputCount()));
if (kind_ == kTruncDivMod) {
return kTagged;
- } else if (kind_ == kSinCos) {
- return kUnboxedDouble;
} else {
UNIMPLEMENTED();
return kTagged;
@@ -7495,7 +7482,6 @@ class MergedMathInstr : public PureDefinition {
static const char* KindToCString(MergedMathInstr::Kind kind) {
if (kind == kTruncDivMod) return "TruncDivMod";
- if (kind == kSinCos) return "SinCos";
UNIMPLEMENTED();
return "";
}
« no previous file with comments | « runtime/vm/il_printer.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698