Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: third_party/WebKit/Source/core/dom/Fullscreen.cpp

Issue 2658703006: Measure requestFullscreen() replacing the pending element (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All
7 * rights reserved. 7 * rights reserved.
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
9 * (http://www.torchmobile.com/) 9 * (http://www.torchmobile.com/)
10 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 463 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 continue; 474 continue;
475 } 475 }
476 476
477 // 4. Otherwise, do nothing for this document. It stays the same. 477 // 4. Otherwise, do nothing for this document. It stays the same.
478 } while (++current != docs.end()); 478 } while (++current != docs.end());
479 479
480 from(document).m_forCrossProcessDescendant = forCrossProcessDescendant; 480 from(document).m_forCrossProcessDescendant = forCrossProcessDescendant;
481 481
482 // 5. Return, and run the remaining steps asynchronously. 482 // 5. Return, and run the remaining steps asynchronously.
483 // 6. Optionally, perform some animation. 483 // 6. Optionally, perform some animation.
484 if (from(document).m_pendingFullscreenElement) {
485 UseCounter::count(document,
486 UseCounter::FullscreenRequestWithPendingElement);
487 }
484 from(document).m_pendingFullscreenElement = &element; 488 from(document).m_pendingFullscreenElement = &element;
485 document.frame()->chromeClient().enterFullscreen(*document.frame()); 489 document.frame()->chromeClient().enterFullscreen(*document.frame());
486 490
487 // 7. Optionally, display a message indicating how the user can exit 491 // 7. Optionally, display a message indicating how the user can exit
488 // displaying the context object fullscreen. 492 // displaying the context object fullscreen.
489 return; 493 return;
490 } while (false); 494 } while (false);
491 495
492 from(document).enqueueErrorEvent(element, requestType); 496 from(document).enqueueErrorEvent(element, requestType);
493 } 497 }
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
863 DEFINE_TRACE(Fullscreen) { 867 DEFINE_TRACE(Fullscreen) {
864 visitor->trace(m_pendingFullscreenElement); 868 visitor->trace(m_pendingFullscreenElement);
865 visitor->trace(m_fullscreenElementStack); 869 visitor->trace(m_fullscreenElementStack);
866 visitor->trace(m_currentFullScreenElement); 870 visitor->trace(m_currentFullScreenElement);
867 visitor->trace(m_eventQueue); 871 visitor->trace(m_eventQueue);
868 Supplement<Document>::trace(visitor); 872 Supplement<Document>::trace(visitor);
869 ContextLifecycleObserver::trace(visitor); 873 ContextLifecycleObserver::trace(visitor);
870 } 874 }
871 875
872 } // namespace blink 876 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698