Convert AudioParam Audit tests to testharness

Convert AudioParam Audit tests to testharness

This were converted automatically using the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

The following files needed to be updated manually to remove the uses
of testPassed/testFailed:

audioparam-automation-clamping.html
audioparam-large-endtime.html
audioparam-linearRamp-value-attribute.html
audioparam-method-chaining.html
audioparam-nominal-range.html
audioparam-sampling.html
audioparam-setTargetAtTime-continuous.html
audioparam-setTargetAtTime-limit.html
audioparam-setValueCurve-copy.html
audioparam-setValueCurve-duration.html
audioparam-setValueCurve-exceptions.html
audioparam-setValueCurveAtTime-interpolation.html
audioparam-update-value-attribute.html

BUG=685355
TEST=

Review-Url: https://codereview.chromium.org/2658703002
Cr-Commit-Position: refs/heads/master@{#446814}
Committed: https://chromium.googlesource.com/chromium/src/+/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868

[Raymond Toy, 2017-01-25 23:48:02]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-01-25 23:48:03]

PTAL

[hongchan, 2017-01-26 22:44:33]

We're not doing var => let?

If all of this test passes, please consider run clang-format on the entire CL. I
would LOVE that.

https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping-expected.txt
(right):

https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping-expected.txt:7:
Harness: the test ran to completion.
Just curious. The label says "D", so we can be sure that this file will be gone.
Right?

If not, we have to get rid of this file from the CL manually.

https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html
(right):

https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html:362:

A redundant empty line.

[Raymond Toy, 2017-01-26 23:25:02]

On 2017/01/26 22:44:33, hongchan wrote:
> We're not doing var => let?
> 
> If all of this test passes, please consider run clang-format on the entire CL.
I
> would LOVE that.

I don't think we should do either for this CL because for the most part it was
done by script except for a few manual changes to remove bare
testPassed/testFailed.

> 
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping-expected.txt
> (right):
> 
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping-expected.txt:7:
> Harness: the test ran to completion.
> Just curious. The label says "D", so we can be sure that this file will be
gone.
> Right?

No, I don't think so. I did remove it, but in the next patch, I restored it
because these files have console log output that I thought we might want to
keep.
> 
> If not, we have to get rid of this file from the CL manually.
> 
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> File
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html
> (right):
> 
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html:362:
> 
> A redundant empty line.

[hongchan, 2017-01-27 17:01:39]

On 2017/01/26 23:25:02, Raymond Toy wrote:
> On 2017/01/26 22:44:33, hongchan wrote:
> > We're not doing var => let?
> > 
> > If all of this test passes, please consider run clang-format on the entire
CL.
> I
> > would LOVE that.
> 
> I don't think we should do either for this CL because for the most part it was
> done by script except for a few manual changes to remove bare
> testPassed/testFailed.
> 
> > 
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> > File
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping-expected.txt
> > (right):
> > 
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping-expected.txt:7:
> > Harness: the test ran to completion.
> > Just curious. The label says "D", so we can be sure that this file will be
> gone.
> > Right?
> 
> No, I don't think so. I did remove it, but in the next patch, I restored it
> because these files have console log output that I thought we might want to
> keep.
> > 
> > If not, we have to get rid of this file from the CL manually.
> > 
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> > File
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html
> > (right):
> > 
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html:362:
> > 
> > A redundant empty line.

I think we should at least leave a note about what needs to be done in these
file. 
I won't be able to come back and say "oh we decided to do this and that".

[Raymond Toy, 2017-01-27 17:42:09]

On 2017/01/27 17:01:39, hongchan wrote:
> On 2017/01/26 23:25:02, Raymond Toy wrote:
> > On 2017/01/26 22:44:33, hongchan wrote:
> > > We're not doing var => let?
> > > 
> > > If all of this test passes, please consider run clang-format on the entire
> CL.
> > I
> > > would LOVE that.
> > 
> > I don't think we should do either for this CL because for the most part it
was
> > done by script except for a few manual changes to remove bare
> > testPassed/testFailed.
> > 
> > > 
> > >
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> > > File
> > >
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping-expected.txt
> > > (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> > >
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping-expected.txt:7:
> > > Harness: the test ran to completion.
> > > Just curious. The label says "D", so we can be sure that this file will be
> > gone.
> > > Right?
> > 
> > No, I don't think so. I did remove it, but in the next patch, I restored it
> > because these files have console log output that I thought we might want to
> > keep.
> > > 
> > > If not, we have to get rid of this file from the CL manually.
> > > 
> > >
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> > > File
> > >
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html
> > > (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> > >
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html:362:
> > > 
> > > A redundant empty line.
> 
> I think we should at least leave a note about what needs to be done in these
> file. 
> I won't be able to come back and say "oh we decided to do this and that".

Sorry, I don't follow.  The bug is about converting to testharness.  We're doing
that.

[hongchan, 2017-01-27 17:57:27]

On 2017/01/27 17:42:09, Raymond Toy wrote:
> On 2017/01/27 17:01:39, hongchan wrote:
> > On 2017/01/26 23:25:02, Raymond Toy wrote:
> > > On 2017/01/26 22:44:33, hongchan wrote:
> > > > We're not doing var => let?
> > > > 
> > > > If all of this test passes, please consider run clang-format on the
entire
> > CL.
> > > I
> > > > would LOVE that.
> > > 
> > > I don't think we should do either for this CL because for the most part it
> was
> > > done by script except for a few manual changes to remove bare
> > > testPassed/testFailed.
> > > 
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> > > > File
> > > >
> > >
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping-expected.txt
> > > > (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> > > >
> > >
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping-expected.txt:7:
> > > > Harness: the test ran to completion.
> > > > Just curious. The label says "D", so we can be sure that this file will
be
> > > gone.
> > > > Right?
> > > 
> > > No, I don't think so. I did remove it, but in the next patch, I restored
it
> > > because these files have console log output that I thought we might want
to
> > > keep.
> > > > 
> > > > If not, we have to get rid of this file from the CL manually.
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> > > > File
> > > >
> > >
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html
> > > > (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> > > >
> > >
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html:362:
> > > > 
> > > > A redundant empty line.
> > 
> > I think we should at least leave a note about what needs to be done in these
> > file. 
> > I won't be able to come back and say "oh we decided to do this and that".
> 
> Sorry, I don't follow.  The bug is about converting to testharness.  We're
doing
> that.

I think it would be great to have some sort of meta bug tracker entry for test
conversion chores. Although this conversion is mechanical, it generates many
things to be done and we are not tracking that. I am not saying we should do it
in this CL, but it's just an idea/suggestion. We will probably forget things
that we discussed here like "oh this is wrong, we should fix it some day".

lgtm

[Raymond Toy, 2017-01-27 19:00:51]

On 2017/01/27 17:57:27, hongchan wrote:
> On 2017/01/27 17:42:09, Raymond Toy wrote:
> > On 2017/01/27 17:01:39, hongchan wrote:
> > > On 2017/01/26 23:25:02, Raymond Toy wrote:
> > > > On 2017/01/26 22:44:33, hongchan wrote:
> > > > > We're not doing var => let?
> > > > > 
> > > > > If all of this test passes, please consider run clang-format on the
> entire
> > > CL.
> > > > I
> > > > > would LOVE that.
> > > > 
> > > > I don't think we should do either for this CL because for the most part
it
> > was
> > > > done by script except for a few manual changes to remove bare
> > > > testPassed/testFailed.
> > > > 
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> > > > > File
> > > > >
> > > >
> > >
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping-expected.txt
> > > > > (right):
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> > > > >
> > > >
> > >
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping-expected.txt:7:
> > > > > Harness: the test ran to completion.
> > > > > Just curious. The label says "D", so we can be sure that this file
will
> be
> > > > gone.
> > > > > Right?
> > > > 
> > > > No, I don't think so. I did remove it, but in the next patch, I restored
> it
> > > > because these files have console log output that I thought we might want
> to
> > > > keep.
> > > > > 
> > > > > If not, we have to get rid of this file from the CL manually.
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> > > > > File
> > > > >
> > > >
> > >
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html
> > > > > (right):
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/2658703002/diff/20001/third_party/WebKit/Layo...
> > > > >
> > > >
> > >
> >
>
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html:362:
> > > > > 
> > > > > A redundant empty line.
> > > 
> > > I think we should at least leave a note about what needs to be done in
these
> > > file. 
> > > I won't be able to come back and say "oh we decided to do this and that".
> > 
> > Sorry, I don't follow.  The bug is about converting to testharness.  We're
> doing
> > that.
> 
> I think it would be great to have some sort of meta bug tracker entry for test
> conversion chores. Although this conversion is mechanical, it generates many
> things to be done and we are not tracking that. I am not saying we should do
it
> in this CL, but it's just an idea/suggestion. We will probably forget things
> that we discussed here like "oh this is wrong, we should fix it some day".
> 
> lgtm

I haven't filed the bug, but I think it's pretty clear to us that the next step
after testharness is to convert old Audit to new Audit.

[Raymond Toy, 2017-01-27 19:01:04]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-01-27 19:01:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 20:39:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 20:39:13]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Raymond Toy, 2017-01-27 21:50:28]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-01-27 21:50:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2658703002/#ps60001
(title: "Rebase test")

[commit-bot: I haz the power, 2017-01-27 21:51:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 23:08:20]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485553828249580,
"parent_rev": "59734505205095774d8696ebfeca11e7cc368331", "commit_rev":
"ec0443b5eca883e0cdeb2f8940cf8faa34dc9868"}

[commit-bot: I haz the power, 2017-01-27 23:08:51]

Description was changed from

==========
Convert AudioParam Audit tests to testharness

This were converted automatically using the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

The following files needed to be updated manually to remove the uses
of testPassed/testFailed:

audioparam-automation-clamping.html
audioparam-large-endtime.html
audioparam-linearRamp-value-attribute.html
audioparam-method-chaining.html
audioparam-nominal-range.html
audioparam-sampling.html
audioparam-setTargetAtTime-continuous.html
audioparam-setTargetAtTime-limit.html
audioparam-setValueCurve-copy.html
audioparam-setValueCurve-duration.html
audioparam-setValueCurve-exceptions.html
audioparam-setValueCurveAtTime-interpolation.html
audioparam-update-value-attribute.html

BUG=685355
TEST=
==========

to

==========
Convert AudioParam Audit tests to testharness

This were converted automatically using the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

The following files needed to be updated manually to remove the uses
of testPassed/testFailed:

audioparam-automation-clamping.html
audioparam-large-endtime.html
audioparam-linearRamp-value-attribute.html
audioparam-method-chaining.html
audioparam-nominal-range.html
audioparam-sampling.html
audioparam-setTargetAtTime-continuous.html
audioparam-setTargetAtTime-limit.html
audioparam-setValueCurve-copy.html
audioparam-setValueCurve-duration.html
audioparam-setValueCurve-exceptions.html
audioparam-setValueCurveAtTime-interpolation.html
audioparam-update-value-attribute.html

BUG=685355
TEST=

Review-Url: https://codereview.chromium.org/2658703002
Cr-Commit-Position: refs/heads/master@{#446814}
Committed:
https://chromium.googlesource.com/chromium/src/+/ec0443b5eca883e0cdeb2f8940cf...
==========

[commit-bot: I haz the power, 2017-01-27 23:08:52]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ec0443b5eca883e0cdeb2f8940cf...