third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-update-value-attribute.html - Issue 2658703002: Convert AudioParam Audit tests to testharness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-update-value-attribute.html

Issue 2658703002: Convert AudioParam Audit tests to testharness (Closed)

Patch Set: Rebase test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation-expected.txt ('k') | third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-update-value-attribute-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-update-value-attribute.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-update-value-attribute.html b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-update-value-attribute.html

index 5d59542a3375722b6138a6b83b08f77a93bf72ce..2887f017c383a3363968617fc2c620a31ef3231f 100644

--- a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-update-value-attribute.html

+++ b/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-update-value-attribute.html

@@ -1,7 +1,8 @@

<!doctype html>

<html>

<head>

- <script src="../../resources/js-test.js"></script>

+ <script src="../../resources/testharness.js"></script>

+ <script src="../../resources/testharnessreport.js"></script>

@@ -10,8 +11,6 @@

<body>

- description("Test Updating of Value Attribute from Timeline");

- window.jsTestIsAsync = true;

// This should be a power of two so that all time computations have no round-off errors.

var sampleRate = 32768;

@@ -84,7 +83,6 @@

});

audit.defineTask("finish", function (done) {

- finishJSTest();

done();

});

@@ -124,8 +122,11 @@

var test = testFunction(gain, v0, t0, v1, t1);

// Print an informative message about the test being run.

- testPassed("Initialize " + test.message + " with setValueAtTime(" + v0 + ", " + t0 + ").");

+ //testPassed("Initialize " + test.message + " with setValueAtTime(" + v0 + ", " + t0 + ").");

+ Should("Initialize", true)

+ .summarize(test.message + " with setValueAtTime(" + v0 + ", " + t0 + ")",

+ "");

var success = true;

// Max relative error found for this test. This is printed if the test fails so that setting

@@ -159,12 +160,9 @@

return context.startRendering().then(function (resultBuffer) {

// Just print a final pass (or fail) message.

- if (success)

- testPassed("Gain .value attribute correctly updated during automation.\n");

- else

- testFailed(

- "Gain .value attribute not correctly updated during automation; max error = " +

- maxError + ".\n");

+ Should("Gain .value attribute", success)

+ .summarize("correctly updated during automation",

+ "not correctly updated during automation; max error = " + maxError);

});

}

</script>