Allow embedder to force visibility of permanent nodes

Allow embedder to force visibility of permanent nodes

The set of bookmark node initially visible can be controlled by the
embedder (on iOS only "Mobile" node is visible). The order of the
nodes depends on the visibility since the first node must be visible.

BUG=364044
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269771

[blundell, 2014-05-05 13:05:54]

noyau@, can you take a look at this?

[noyau (Ping after 24h), 2014-05-05 13:36:11]

lgtm

[blundell, 2014-05-05 13:37:05]

Rubberstamp LGTM for OWNERS

[sdefresne, 2014-05-06 12:59:56]

PTAL to chrome_bookmark_client.cc

[sdefresne, 2014-05-06 13:02:00]

+zea for OWNERS of chrome/browser/sync/glue

[blundell, 2014-05-07 15:07:23]

lgtm

[Nicolas Zea, 2014-05-07 17:02:58]

lgtm

[sdefresne, 2014-05-07 18:57:45]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-05-07 18:59:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sdefresne@chromium.org/265853002/40001

[commit-bot: I haz the power, 2014-05-08 05:44:42]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
  linux_chromium_chromeos_rel on tryserver.chromium
  linux_chromium_rel on tryserver.chromium
  mac_chromium_rel on tryserver.chromium
  win_chromium_compile_dbg on tryserver.chromium
  win_chromium_rel on tryserver.chromium
  win_chromium_x64_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-08 05:48:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-08 05:48:01]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
  linux_chromium_rel on tryserver.chromium

[tfarina, 2014-05-09 03:09:44]

https://codereview.chromium.org/265853002/diff/40001/components/bookmarks/cor...
File components/bookmarks/core/browser/bookmark_model.cc (right):

https://codereview.chromium.org/265853002/diff/40001/components/bookmarks/cor...
components/bookmarks/core/browser/bookmark_model.cc:682: ->set_visible(value ||
client_->IsPermanentNodeVisible(type));
is this the format produced by clang-format? If yes, I'd do a manual format to
something like this:

AsMutable(PermanentNode(type)->set_visible(
    value || ...));

I think we are used to keep -> in the preceding line.

I'd suggest filing a bug against clang-format too.

[sdefresne, 2014-05-09 08:57:39]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-05-09 09:04:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sdefresne@chromium.org/265853002/80001

[commit-bot: I haz the power, 2014-05-09 10:51:59]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-05-09 11:57:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 11:57:40]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[sdefresne, 2014-05-12 10:06:21]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-05-12 10:06:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sdefresne@chromium.org/265853002/100001

[commit-bot: I haz the power, 2014-05-12 12:32:20]

Change committed as 269771