Allow embedder to force visibility of permanent nodes

chrome/browser/bookmarks/bookmark_model_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/bookmarks/core/browser/bookmark_model.h"
 
 #include <set>
 #include <string>
 
 #include "base/base_paths.h"
@@ skipping 1043 matching lines @@
 
   // Make sure the order matches is correct (it should be reversed).
   ASSERT_EQ(4, parent->child_count());
   EXPECT_EQ("D", base::UTF16ToASCII(parent->GetChild(0)->GetTitle()));
   EXPECT_EQ("C", base::UTF16ToASCII(parent->GetChild(1)->GetTitle()));
   EXPECT_EQ("B", base::UTF16ToASCII(parent->GetChild(2)->GetTitle()));
   EXPECT_EQ("A", base::UTF16ToASCII(parent->GetChild(3)->GetTitle()));
 }
 
 TEST_F(BookmarkModelTest, NodeVisibility) {
+  // Mobile node invisible by default
   EXPECT_TRUE(model_->bookmark_bar_node()->IsVisible());
   EXPECT_TRUE(model_->other_node()->IsVisible());
-  // Mobile node invisible by default
   EXPECT_FALSE(model_->mobile_node()->IsVisible());
 
-  // Change visibility of permanent nodes.
+  // Visibility of permanent node can only be changed if they are not
+  // forced to be visible by the client.
   model_->SetPermanentNodeVisible(BookmarkNode::BOOKMARK_BAR, false);
-  EXPECT_FALSE(model_->bookmark_bar_node()->IsVisible());
+  EXPECT_TRUE(model_->bookmark_bar_node()->IsVisible());
   model_->SetPermanentNodeVisible(BookmarkNode::OTHER_NODE, false);
-  EXPECT_FALSE(model_->other_node()->IsVisible());
+  EXPECT_TRUE(model_->other_node()->IsVisible());
   model_->SetPermanentNodeVisible(BookmarkNode::MOBILE, true);
   EXPECT_TRUE(model_->mobile_node()->IsVisible());
+  model_->SetPermanentNodeVisible(BookmarkNode::MOBILE, false);
+  EXPECT_FALSE(model_->mobile_node()->IsVisible());
 
   // Arbitrary node should be visible
   TestNode bbn;
   PopulateNodeFromString("B", &bbn);
-  const BookmarkNode* parent = model_->bookmark_bar_node();
+  const BookmarkNode* parent = model_->mobile_node();
   PopulateBookmarkNode(&bbn, model_.get(), parent);
   EXPECT_TRUE(parent->GetChild(0)->IsVisible());
 
-  // Bookmark bar should be visible now that it has a child.
-  EXPECT_TRUE(model_->bookmark_bar_node()->IsVisible());
+  // Mobile folder should be visible now that it has a child.
+  EXPECT_TRUE(model_->mobile_node()->IsVisible());
 }
 
 TEST_F(BookmarkModelTest, MobileNodeVisibileWithChildren) {
   const BookmarkNode* root = model_->mobile_node();
   const base::string16 title(ASCIIToUTF16("foo"));
   const GURL url("http://foo.com");
 
   model_->AddURL(root, 0, title, url);
   EXPECT_TRUE(model_->mobile_node()->IsVisible());
 }
@@ skipping 52 matching lines @@
   EXPECT_TRUE(node.DeleteMetaInfo("key2.subkey2.leaf"));
   EXPECT_FALSE(node.DeleteMetaInfo("key3"));
   EXPECT_FALSE(node.GetMetaInfo("key1", &out_value));
   EXPECT_FALSE(node.GetMetaInfo("key2.subkey1", &out_value));
   EXPECT_FALSE(node.GetMetaInfo("key2.subkey2", &out_value));
   EXPECT_FALSE(node.GetMetaInfo("key2.subkey2.leaf", &out_value));
   EXPECT_FALSE(node.GetMetaInfoMap());
 }
 
 }  // namespace