Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: chrome/browser/bookmarks/bookmark_model_unittest.cc

Issue 265853002: Allow embedder to force visibility of permanent nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase & fix BookmarkModelTest.NodeVisibility Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/bookmarks/chrome_bookmark_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/bookmark_model_unittest.cc
diff --git a/chrome/browser/bookmarks/bookmark_model_unittest.cc b/chrome/browser/bookmarks/bookmark_model_unittest.cc
index 8198b21c57d9af5100446b91cc9c8a23f5321ee2..b04d84122cbfcef85170cc62159cffa929c4dd48 100644
--- a/chrome/browser/bookmarks/bookmark_model_unittest.cc
+++ b/chrome/browser/bookmarks/bookmark_model_unittest.cc
@@ -1061,28 +1061,31 @@ TEST_F(BookmarkModelTest, Reorder) {
}
TEST_F(BookmarkModelTest, NodeVisibility) {
+ // Mobile node invisible by default
EXPECT_TRUE(model_->bookmark_bar_node()->IsVisible());
EXPECT_TRUE(model_->other_node()->IsVisible());
- // Mobile node invisible by default
EXPECT_FALSE(model_->mobile_node()->IsVisible());
- // Change visibility of permanent nodes.
+ // Visibility of permanent node can only be changed if they are not
+ // forced to be visible by the client.
model_->SetPermanentNodeVisible(BookmarkNode::BOOKMARK_BAR, false);
- EXPECT_FALSE(model_->bookmark_bar_node()->IsVisible());
+ EXPECT_TRUE(model_->bookmark_bar_node()->IsVisible());
model_->SetPermanentNodeVisible(BookmarkNode::OTHER_NODE, false);
- EXPECT_FALSE(model_->other_node()->IsVisible());
+ EXPECT_TRUE(model_->other_node()->IsVisible());
model_->SetPermanentNodeVisible(BookmarkNode::MOBILE, true);
EXPECT_TRUE(model_->mobile_node()->IsVisible());
+ model_->SetPermanentNodeVisible(BookmarkNode::MOBILE, false);
+ EXPECT_FALSE(model_->mobile_node()->IsVisible());
// Arbitrary node should be visible
TestNode bbn;
PopulateNodeFromString("B", &bbn);
- const BookmarkNode* parent = model_->bookmark_bar_node();
+ const BookmarkNode* parent = model_->mobile_node();
PopulateBookmarkNode(&bbn, model_.get(), parent);
EXPECT_TRUE(parent->GetChild(0)->IsVisible());
- // Bookmark bar should be visible now that it has a child.
- EXPECT_TRUE(model_->bookmark_bar_node()->IsVisible());
+ // Mobile folder should be visible now that it has a child.
+ EXPECT_TRUE(model_->mobile_node()->IsVisible());
}
TEST_F(BookmarkModelTest, MobileNodeVisibileWithChildren) {
« no previous file with comments | « no previous file | chrome/browser/bookmarks/chrome_bookmark_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698